Fix subtitle sync races and prepare Bazarr+ v2.6.2 - #429
Merged
Conversation
Preserve later subtitle edits and deletions while background sync runs. Refresh media services after outputs are saved and keep media ownership checks when retiring generated subtitles. Report cleanup errors without losing track of a successfully saved subtitle. Stop Gemini requests and retries after cancellation and clear progress. Follow up on #428.
Render all four cards for zero counts, loading and connection errors. Show a dash for unavailable counts and preserve valid counts when only the jobs list fails.
Prepare the stability patch with subtitle publication, translation, provider handling, routing, upload and dependency corrections. - Stamp package_info with version 2.6.2. - Add 18 in-app release slides and version persistence. - Update the site version and roadmap and archive the release notes. Deploy-verified: the test instance reports 2.6.2, starts cleanly and passes all 18 release-tour slides, ten translator and six upload browser cases.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Add #429 to the complete release inventory.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0487330fc4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Reuse a lazy ownership index within each library scan while keeping mutation checks fresh. Record successful sync promotion even when index refresh fails, and notify media consumers before sync setup can fail after an upload. Cover scan ownership scaling and both publication failure paths with regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background subtitle sync could overwrite a newer edit or recreate a deleted subtitle after #428. This follow-up coordinates subtitle writers and publishes sync results only while their original destination is still current. Ownership checks protect unrelated files, and cleanup errors no longer hide successfully saved subtitles.
Library scans now reuse an ownership index for custom subtitle folders, while mutation checks remain fresh. Successful sync promotions retain confirmation history if index refresh fails. Saved uploads notify media consumers before sync setup or queueing can fail, and refresh them again after successful sync.
Gemini cancellation stops subsequent requests and retries and clears progress. Translator status cards remain visible for zero counts, loading and errors, with a dash for unavailable counts.
The release preparation commit prepares Bazarr+ v2.6.2 (Clockwork): version metadata, 18 in-app release slides, the site entry and archived release notes. This PR targets development; publishing the release is a separate step.
Validation of the combined candidate: