Be more robust about exceptions#10
Open
LaserEyess wants to merge 1 commit into
Open
Conversation
Also suggested by the clanker. Catch more possible exceptions in writer.write() and writer.drain(). If there is an unknown exception that shouldn't occur, flag it and abort. Defense in depth dictates we should assume the worst. This is not a DoS because, well, we're not serving anything. Nothing on the host is compromised. Also add an abort in case `peername` is empty. That should never happen, but if it does, something has gone horribly wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also suggested by the clanker. Catch more possible exceptions in writer.write() and writer.drain(). If there is an unknown exception that shouldn't occur, flag it and abort. Defense in depth dictates we should assume the worst. This is not a DoS because, well, we're not serving anything. Nothing on the host is compromised.
Also add an abort in case
peernameis empty. That should never happen, but if it does, something has gone horribly wrong.