Merged
Conversation
Adds real-time progress feedback to the `uvm install` command using indicatif progress bars. Interactive terminals show per-component download progress with speed and ETA, followed by installation sub-phase spinners. Non-interactive environments (pipes, CI) fall back to milestone log lines. * ![ADD] `ProgressHandler` trait with `set_message`, `initialize_components`, `get_component_handler`, and `begin_extraction_progress` methods * ![ADD] `MultiProgressCoordinator` with per-component progress bars, phase-level spinners, and overall component counter * ![ADD] `IndicatifProgressHandler` wrapping indicatif `ProgressBar`; switches between download bar, spinner, and extraction bar styles based on installation phase * ![ADD] `SimpleProgressHandler` fallback for non-TTY/CI environments printing milestone messages to stderr * ![ADD] `begin_extraction_progress` for determinate byte-level progress during ZIP extraction (two-pass: sum central directory sizes, then `inc` per file) * ![ADD] Sub-phase progress messages in pkg installers (macOS/Linux): `Unpacking…` → `Extracting…` → `Installing…` * ![ADD] `--progress` / `--no-progress` flags to force-override TTY detection * ![ADD] `indicatif_log_bridge` integration so verbose log output suspends bars rather than corrupting them * ![ADD] Installation summary printed after success (elapsed time, bytes downloaded, components installed) * ![UPDATE] `create_installer` on all platforms accepts `Option<Box<dyn ProgressHandler>>` and wires it into the installer structs via a `with_progress` builder * ![UPDATE] `Installer<V, T, I>` struct carries an optional `Box<dyn ProgressHandler>` field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds real-time progress feedback to the
uvm installcommand using indicatif progress bars. Interactive terminals show per-component download progress with speed and ETA, followed by installation sub-phase spinners. Non-interactive environments (pipes, CI) fall back to milestone log lines.ProgressHandlertrait withset_message,initialize_components,get_component_handler, andbegin_extraction_progressmethodsMultiProgressCoordinatorwith per-component progress bars, phase-level spinners, and overall component counterIndicatifProgressHandlerwrapping indicatifProgressBar; switches between download bar, spinner, and extraction bar styles based on installation phaseSimpleProgressHandlerfallback for non-TTY/CI environments printing milestone messages to stderrbegin_extraction_progressfor determinate byte-level progress during ZIP extraction (two-pass: sum central directory sizes, thenincper file)Unpacking…→Extracting…→Installing…--progress/--no-progressflags to force-override TTY detectionindicatif_log_bridgeintegration so verbose log output suspends bars rather than corrupting themcreate_installeron all platforms acceptsOption<Box<dyn ProgressHandler>>and wires it into the installer structs via awith_progressbuilderInstaller<V, T, I>struct carries an optionalBox<dyn ProgressHandler>field