Add configurable movement keys#304
Open
tahminator wants to merge 6 commits into
Open
Conversation
…ser keybindings instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow movement keys (usually
h/j/k/l) to be configurable by user insteadNote
arrow keys still work the same way, allows for movement and cannot be changed
As for why: I built a bad habit of swapping
jandkwherever I use Vim bindings and so this feature would be very helpful to me. I'm honestly not sure how many other people would benefit from this other than me, but I figured I'd put up a PR in case you would like to make this a feature 😄Testing
All tests passing:
I have also been dogfooding the changes for the past day, haven't noticed anything broken
Additional notes