Skip to content

Couple of code examples updated and their formatting made consistent#478

Open
tomsb wants to merge 2 commits into
Laravel-Backpack:masterfrom
tomsb:master
Open

Couple of code examples updated and their formatting made consistent#478
tomsb wants to merge 2 commits into
Laravel-Backpack:masterfrom
tomsb:master

Conversation

@tomsb

@tomsb tomsb commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@pxpm

pxpm commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

Hey @tomsb thanks for the PR 🙏

The only thing I think we should merge is the fix in the join example by changing select (the name of the column we use in demo 🙃 by category_id, what makes sense in a real project.

Can you please clean up this PR a leave only that change ?

We can discuss the other later, but I really don't think they are worth poluting the docs with.

Once again, thank you very much 🙏

Cheers

@pxpm pxpm self-assigned this Jul 26, 2023
…s within the limit", so that they are not polluting the docs
@tomsb

tomsb commented Jul 27, 2023

Copy link
Copy Markdown
Contributor Author

Removed the polluting stuff, but the other changes look good (some formatting and bug fixes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

2 participants