Skip to content

Fix/issue 632 dashboard form a11y - #992

Open
Benedict315 wants to merge 3 commits into
LabsCrypt:mainfrom
Benedict315:fix/issue-632-dashboard-form-a11y
Open

Fix/issue 632 dashboard form a11y#992
Benedict315 wants to merge 3 commits into
LabsCrypt:mainfrom
Benedict315:fix/issue-632-dashboard-form-a11y

Conversation

@Benedict315

Copy link
Copy Markdown
Contributor

Description

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test addition or update

Related Issues

Closes #632

Changes Made

Testing

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Test Steps

Breaking Changes

Breaking Changes:

Migration Guide:

Screenshots/Demo

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have checked for breaking changes and documented them if applicable

Additional Notes

@Benedict315
Benedict315 force-pushed the fix/issue-632-dashboard-form-a11y branch from 1971738 to 826162d Compare July 11, 2026 17:10

@ogazboiz ogazboiz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the a11y hunk itself is fine, but note main's labels already wrap their inputs (valid implicit association), so please confirm which control was actually failing the #632 audit. blockers:

  1. remove the Cargo.toml [patch.crates-io] ethnum entry, it points at the same source and breaks every rust CI job ("patches must point to different sources").
  2. remove the soroban-sdk bump and the backend/frontend vitest bumps, dependency updates are dependabot's job.
  3. keep only the dashboard-view.tsx hunk.

if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Frontend] Dashboard settings tab form: bare-string labels with no htmlFor association

3 participants