fix: frontend component refactors, dead code cleanup, and docs update (#580, #581, #582, #583) - #590
Merged
Merged
Conversation
added 4 commits
May 30, 2026 03:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request bundles fixes for frontend consistency, code cleanliness, and documentation accuracy in the FlowFi repository.
Closes
Changes Included
Duplicated duration-unit-to-seconds constants ([Frontend] Duplicated duration-unit-to-seconds constants (ScheduleStep vs lib/soroban) #580)
SECONDS_PER_UNITmap andDurationUnittype fromfrontend/src/lib/soroban.ts.ScheduleStep.tsxto use the shared constants instead of inline magic numbers and switch statements for calculatingtotalSeconds.Dead code in WalletButton ([Frontend] Remove commented-out dead code in WalletButton #581)
WalletButton.tsxby removing the commented-outnetworkLabellogic and the abandonedwallet-chip__name/wallet-chip__networkmarkup.Global timeout shadowing ([Frontend] StreamCreationWizard shadows global 'timeout' with a state variable #582)
timeoutstate variable inStreamCreationWizard.tsxtotimeoutErrorto prevent shadowing the globaltimeoutfunction.{timeoutError ? ... : ...}).setTimeoutcalls in the polling function.Postgres Port Mismatch in Docs ([Docs] README states Postgres on port 5432 but docker-compose maps 5433 #583)
README.mdto state the correct host port5433(matching thedocker-compose.ymlmapping).backend/.env.exampleto point theDATABASE_URLandSANDBOX_DATABASE_URLexamples tolocalhost:5433.Verification
WalletButton.tsxis cleaner and maintains full expected functionality.StreamCreationWizard.tsxcontinues to work properly and the code is clearer.