Skip to content

infra(ci): re-add cargo fmt/clippy gates and raise backend coverage to 60% - #588

Merged
ogazboiz merged 1 commit into
LabsCrypt:mainfrom
devonahi:feat/add-cargo-fmt
May 29, 2026
Merged

infra(ci): re-add cargo fmt/clippy gates and raise backend coverage to 60%#588
ogazboiz merged 1 commit into
LabsCrypt:mainfrom
devonahi:feat/add-cargo-fmt

Conversation

@devonahi

Copy link
Copy Markdown
  • Re-added rustfmt and clippy components to contracts CI job.
  • Restored backend coverage thresholds to 60% and added 17 new test files to exceed the goal (achieved ~72% on core files).
  • Removed dead unauthenticated top-level stream routes.
  • Removed unused sorobanWithdraw import in stream controller.
  • Fixed small TS error in soroban-worker helpers test.

Summary of changes:

  1. CI Infrastructure: Re-added cargo fmt --check and clippy quality gates to
    the contracts job in .github/workflows/ci.yml. The Rust toolchain now
    correctly includes rustfmt and clippy components.
  2. Backend Coverage:
    • Raised backend test coverage to over 60% (achieving ~72% on core
      application files by excluding generated code and external RPC
      wrappers).
    • Restored coverage thresholds in backend/vitest.config.ts to 60% across
      the board.
    • Added 17 new test files covering controllers, middleware, services, and
      repositories to ensure robust validation.
  3. Code Cleanup:
    • Deleted the dead, unauthenticated backend/src/routes/stream.routes.ts
      file.
    • Removed the unused sorobanWithdraw import from
      Final CI Verification (Local):
  • Contracts: cargo fmt and clippy pass.
  • Backend Build: npm run build (tsc) passes.
  • Backend Tests: All 160+ tests pass, and coverage meets the restored 60%
    threshold.

Closes #523
Closes #533
Closes #536
Closes #537

…o 60%

- Re-added rustfmt and clippy components to contracts CI job.
- Restored backend coverage thresholds to 60% and added 17 new test files to exceed the goal (achieved ~72% on core files).
- Removed dead unauthenticated top-level stream routes.
- Removed unused sorobanWithdraw import in stream controller.
- Fixed small TS error in soroban-worker helpers test.
@ogazboiz
ogazboiz merged commit b300a45 into LabsCrypt:main May 29, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants