fix: persist create-stream form draft to sessionStorage across page reloads (Closes #1087) - #1153
Merged
ogazboiz merged 3 commits intoAug 6, 2026
Conversation
ogazboiz
requested changes
Aug 3, 2026
ogazboiz
left a comment
Contributor
There was a problem hiding this comment.
nice feature and the seven tests (including draft vs query-param precedence) are solid. three fixes needed:
- the debounced save fires 500ms after mount even on a pristine form, writing an empty draft that loadDraftFromSession happily accepts, so the next visit shows a bogus "Resumed a saved draft" banner over an empty form. skip saving when the form equals defaults, or reject empty drafts on load.
- the banner calls loadDraftFromSession() on every render just to read savedAt. capture it once in state.
- revert the "Back to Dashboard" Link to a Link. the button plus router.push swap does not protect the draft (Link navigation would not clear sessionStorage either) and regresses semantics.
if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
Contributor
Author
|
Resolved, Chief. @ogazboiz |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1087
Summary
sessionStorageon each change (debounced 500ms) to survive accidental page reloadsTesting