Skip to content

feat(core): O-13 PR4 ArenaLifecycleCoordinatorV1 unified lifecycle + zero-alloc gate - #635

Open
lemone112 wants to merge 1 commit into
mainfrom
o13/lifecycle-coordinator
Open

feat(core): O-13 PR4 ArenaLifecycleCoordinatorV1 unified lifecycle + zero-alloc gate#635
lemone112 wants to merge 1 commit into
mainfrom
o13/lifecycle-coordinator

Conversation

@lemone112

Copy link
Copy Markdown
Collaborator

Summary

Implements the ArenaLifecycleCoordinatorV1 per IMPL-SPEC-o13-pr4-lifecycle-coordinator.md. Coordinates lifecycle transitions across observation, field raster, and report arena pools with atomic reset, release, and generation tracking.

Replaces closed PR #632 with updated branch state rebased on current main.

Types Added

  • ArenaGenerationV1 — monotonic generation counter for slot validity detection
  • ArenaLifecycleCoordinatorV1 — coordinates reset_all / release_all_slots across all three pool types
  • ArenaRebindErrorV1 — typed error enum for partial-failure detection during schema rebind

Pool Extensions

  • ObservationArenaPoolV1: added release_all(), high_water_mark(), generation field in backing
  • FieldRasterArenaPoolV1: added reset_extent(), release_all(), high_water_mark(), generation field in backing
  • ReportArenaPoolV1: added reset(), release_all(), generation field in backing

Tests (13 total)

  • 5 unit tests: coordinator construction, generation increment, capacity preservation, unique ownership after release, staleness detection
  • 5 integration tests: zero-allocation gate (10K iterations), high-water mark bounds, atomic schema rebind success, partial failure detectability, byte identity preservation
  • 3 property tests: generation monotonicity, slot count invariant, zero-alloc closure per transition type

Gate Results

  • cargo check --workspace: PASS
  • cargo test --workspace: PASS (all tests green)
  • cargo clippy --workspace --all-targets -- -D warnings: CLEAN
  • cargo fmt --check: CLEAN
  • RUSTDOCFLAGS=-D warnings cargo doc --workspace --no-deps: PASS
  • verify_clean_set_receipt.py: PRODUCT_IDENTITY_VERIFIED
  • verify_point_support_surplus.py: PASS

V7 Staging Compliance

  • All new types are pub(crate) with #[expect(dead_code)]
  • Zero .unwrap()/.expect() in production paths
  • Zero unsafe blocks
  • No new public exports from packages/colors/index.js or index.d.ts
  • Infrastructure only — no authority minting

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your current included review allowance is based on your included PR review attempts over the past 7 days.

Next review available in: 5 minutes

Limit details: You’ve used the included review currently available. Your 101 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7d2b7569-70f4-40b2-b8c0-432ad7523954

📥 Commits

Reviewing files that changed from the base of the PR and between da6f2d6 and e5f5d28.

📒 Files selected for processing (10)
  • crates/labcolors-core/contracts/clean-set-srgb8-v1/receipt-v1.json
  • crates/labcolors-core/contracts/clean-set-srgb8-v1/receipt-v1.sha256
  • crates/labcolors-core/contracts/point-support-reference-surplus-q55-bps-proof-v1.json
  • crates/labcolors-core/src/arena_lifecycle.rs
  • crates/labcolors-core/src/field_arena.rs
  • crates/labcolors-core/src/lib.rs
  • crates/labcolors-core/src/observation.rs
  • crates/labcolors-core/src/report_arena.rs
  • scripts/_canonical_receipt.py
  • scripts/verify_point_support_surplus.py

Comment @coderabbitai help to get the list of available commands.

@lemone112
lemone112 force-pushed the o13/lifecycle-coordinator branch 3 times, most recently from 50147e2 to 9dc362c Compare August 23, 2026 02:17
@lemone112
lemone112 force-pushed the o13/lifecycle-coordinator branch from 9dc362c to e5f5d28 Compare August 23, 2026 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant