move response topic default off $SYS + reactive peer-mode design doc#11
Merged
move response topic default off $SYS + reactive peer-mode design doc#11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
responseTopicPrefixmoved from$SYS/responsesto$DB/clients. The MQTT 5 spec (§4.7.2) reserves$-prefixed topics for broker-internal use; production brokers (EMQX, HiveMQ, AWS IoT Core) reject client publishes under$SYSby default ACL. The field remains fully configurable — deployments depending on the old default can preserve behavior by settingresponseTopicPrefix: '$SYS/responses'explicitly.handleResponseMessagewith astartsWith-based check. The old regex prepended\$to the prefix, which only worked when the prefix started with$— any non-$override produced an invalid regex (\rwas interpreted as carriage return).docs/design/reactive-peer-mode.md— design doc for an upcoming peer-coordinated sync mode that lets stitch run against a plain MQTT broker without MQDB. Not implemented; for review.Breaking change
Default
responseTopicPrefixchanged. Documented inCHANGELOG.mdunder Unreleased. Deployments overriding the field explicitly are unaffected.Test plan
npm run check(typecheck + lint + format + 35 tests) passesnode scripts/verify-changelog.mjspassesresponseTopicPrefixexplicitly — should be unaffected$DB/clients/...(or setresponseTopicPrefix: '$SYS/responses'to preserve)