Conversation
…rtyDescriptor() doesn't handle multiple filter conditions - factor out XML metadata conditional format parsing and query string generation in ConditionalFormat.java to be reusable - use ConditionalFormat.buildFilterQueryString in DomainUtil.getPropertyDescriptor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
#1056 Unable to apply multiple conditional formats to a Calculation field
DomainUtil.getPropertyDescriptor() was loading conditional format filters from XML metadata by calling gwtFormat.setFilter(...) in a loop, causing each iteration to overwrite the previous filter so only the last one
survived. This PR fixes the bug by extracting the filter-building logic from ConditionalFormat.convertFromXML() into a shared buildFilterQueryString() helper, then calling that from both sites.
Changes