Fix accessibility issues suggested by WAVE#1980
Conversation
|
I think we can wait for the next version bump to pick up these changes. Cory, let us know if you disagree. |
|
We don't really bump the @labkey/themes version too often, so in this case I might suggest that we do bump it with this PR and then put that updated version into the platform/core/package.json to get it applied. That said, I did apply the changes via an alpha package version just to see how it looks. Here is the comparison: @labkey-jeckels @labkey-keegang @ankurjuneja SEATTLE THEME OVERCAST THEME |
|
Thanks Cory. The text/tab contrast is much better, but the tab/background contrast is now very low or maybe non-existent. Do we want to adjust that further, or add a border around the tab? @labkey-keegang |
cnathe
left a comment
There was a problem hiding this comment.
There is some discussions going on regarding the updates. I think we should get an alpha package version of this change and put it into the platform/core package.json so that @labkey-keegang can take a look at this and the other themes. Let me know if you want me to do that step.
Yes please. These colors are probably used in places other than the folder tabs, so it's worth seeing how things look a bit more generally. |




Rationale
https://github.com/LabKey/internal-issues/issues/878
Related Pull Requests
Changes