Skip to content

Fix accessibility issues suggested by WAVE#1980

Open
ankurjuneja wants to merge 2 commits intodevelopfrom
fb_issue878_accessibility_issues
Open

Fix accessibility issues suggested by WAVE#1980
ankurjuneja wants to merge 2 commits intodevelopfrom
fb_issue878_accessibility_issues

Conversation

@ankurjuneja
Copy link
Copy Markdown

Rationale

https://github.com/LabKey/internal-issues/issues/878

Related Pull Requests

Changes

@labkey-jeckels
Copy link
Copy Markdown
Contributor

I think we can wait for the next version bump to pick up these changes. Cory, let us know if you disagree.

@cnathe
Copy link
Copy Markdown
Contributor

cnathe commented Apr 13, 2026

We don't really bump the @labkey/themes version too often, so in this case I might suggest that we do bump it with this PR and then put that updated version into the platform/core/package.json to get it applied.

That said, I did apply the changes via an alpha package version just to see how it looks. Here is the comparison: @labkey-jeckels @labkey-keegang @ankurjuneja

SEATTLE THEME

before
Screenshot 2026-04-13 at 10 17 59 AM

after
Screenshot 2026-04-13 at 10 19 08 AM

OVERCAST THEME

before
Screenshot 2026-04-13 at 10 52 18 AM

after
Screenshot 2026-04-13 at 10 47 08 AM

@labkey-jeckels
Copy link
Copy Markdown
Contributor

Thanks Cory. The text/tab contrast is much better, but the tab/background contrast is now very low or maybe non-existent. Do we want to adjust that further, or add a border around the tab? @labkey-keegang

Copy link
Copy Markdown
Contributor

@cnathe cnathe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some discussions going on regarding the updates. I think we should get an alpha package version of this change and put it into the platform/core package.json so that @labkey-keegang can take a look at this and the other themes. Let me know if you want me to do that step.

@labkey-jeckels
Copy link
Copy Markdown
Contributor

There is some discussions going on regarding the updates. I think we should get an alpha package version of this change and put it into the platform/core package.json so that @labkey-keegang can take a look at this and the other themes. Let me know if you want me to do that step.

Yes please. These colors are probably used in places other than the folder tabs, so it's worth seeing how things look a bit more generally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants