docs: close Req 4's stale (planned) rowid-alias substitution note - #614
Merged
Conversation
Req 4 read as unimplemented ("Covered functionally once #34 lands"),
but #34's DDL reader (rowid_alias_from_sql/TableSchema::rowid_alias)
already landed and substitution is already wired through
src/codegen/select/projection.rs, src/codegen/stmt/insert.rs, and
src/codegen/stmt/update.rs — the note was simply never updated.
Added the one missing piece: a btree-layer unit test proving this
module itself decodes the alias column as Value::Null rather than
substituting (the two existing corpus tests already prove the
higher-layer substitution). Split the requirement into its two
scenarios and linked both to real, passing tests.
spend: trivial (doc correction + one small unit test, no new
production code — the underlying feature was already fully shipped)
iheitlager
force-pushed
the
feat/req4-btree-rowid-alias-substitution
branch
from
August 27, 2026 21:08
f7e4a4b to
77b52eb
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rowid_alias_from_sql/TableSchema::rowid_alias) already landed and substitution is already wired throughsrc/codegen/select/projection.rs,src/codegen/stmt/insert.rs, andsrc/codegen/stmt/update.rs— the note was simply never updated.Value::Nullrather than substituting (the two existing corpus tests already prove the higher-layer substitution). Split the requirement into its two scenarios and linked both to real, passing tests.Test plan
rowid_alias_column_decodes_as_null_not_substitutedcargo test --lib(925 tests), related corpus tests, clippy,make assurance(006-btree Req 4 now 2/2, no dead links) all cleanspend: trivial (doc correction + one small unit test, no new production code — the underlying feature was already fully shipped)
🤖 Generated with Claude Code