chore: regenerate MC/DC obligations, rename shifted tagged tests - #610
Merged
Conversation
iheitlager
force-pushed
the
fix/mcdc-obligations-refresh
branch
2 times, most recently
from
August 27, 2026 20:58
a13865d to
aa1eefa
Compare
PageSource::read_page returns Rc<[u8]> to share page buffers instead of copying, but the fuzz target's FuzzPageSource impl still returned Vec<u8>, breaking `make fuzz-btree`. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ests tests/mcdc/obligations.json had drifted from source line numbers. Regenerated via `make mcdc-obligations` and renamed every mcdc__<id>__vN tagged test (and its doc-comment cross-references) to the id its decision now resolves to, so `unit_mcdc_discharge` and `cargo-mvl-mcdc harvest` join tagged tests to obligations correctly again. This also surfaces the true discharge state: 40/42 real MC/DC obligations are discharged (previously misreported near 0 due to the id drift) — btree_966 and encode_68 remain undischarged. Token spend: trivial, matched estimate (mechanical id rename, no new test logic). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
iheitlager
force-pushed
the
fix/mcdc-obligations-refresh
branch
from
August 27, 2026 21:01
aa1eefa to
1ecbf22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/fuzz/fuzz_targets/btree_cursor.rs:PageSource::read_pagereturnsRc<[u8]>, but the fuzz target'sFuzzPageSourceimpl still returnedVec<u8>, breakingmake fuzz-btree.tests/mcdc/obligations.jsonviamake mcdc-obligations— source edits since it was last committed had shifted decision line numbers.mcdc__<id>__vN_...tagged test (plus doc-comment cross-references) to the obligation id its decision now resolves to, acrosssrc/btree.rs,src/btree/index.rs,src/btree/table/delete.rs,src/parser/grammar.rs,src/parser/tokenizer.rs,src/record/encode.rs,src/vdbe/exec.rs,src/vdbe/functions.rs.This surfaces the true MC/DC discharge state for the scanned file set: 40/42 real multi-leaf obligations discharged (previously ~0/42, because
cargo-mvl-mcdc harvestcouldn't join stale-id tagged tests to current obligations). Two remain undischarged:btree_966(src/btree.rs:966) andencode_68(src/record/encode.rs:68) — out of scope for this PR.Token spend: trivial, matched estimate — mechanical id rename + snapshot regen, no new test logic.
Test plan
cargo test --locked --lib— 924 passedcargo test --locked --test unit_mcdc_discharge— passes (previously failed on staledelete_62id)cargo-mvl-mcdc harvest ... | tools/mcdc_report.py— 40/42 real MC/DC obligations dischargedmake fuzz-btree(60s) — builds and runs clean, no crashescargo fmt --check,cargo clippy --locked --all-targets -D warnings🤖 Generated with Claude Code