Skip to content

Add qu imaging - #126

Open
vijaymahatma wants to merge 39 commits into
masterfrom
add_qu_imaging
Open

Add qu imaging#126
vijaymahatma wants to merge 39 commits into
masterfrom
add_qu_imaging

Conversation

@vijaymahatma

Copy link
Copy Markdown
Member

Adding polarization imaging workflow.

This has been tested on UHHPC, and using the flocs runner such as
flocs-run vlbi polarization-imaging --mspath=../Delay-Calibration_3C351_ep1_delaycal_ddf/facetselfcal/ --ms-suffix=.avg --num-channels 105 --image-size 128 128
produces RM cubes successfully.

@vijaymahatma vijaymahatma self-assigned this Jun 16, 2026
@vijaymahatma
vijaymahatma requested a review from jurjen93 June 16, 2026 17:18
Comment thread scripts/make_pol_cubes.py Outdated
Comment thread scripts/make_pol_cubes.py Outdated
Comment thread scripts/run_rmtools.py

return str(q_local), str(u_local), str(freq_local)

def build_rmsynth_cmd(args: argparse.Namespace, qfile: str, ufile: str, freqfile: str,) -> List[str]:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is written in Python, use instead the Python packages?
For example: https://github.com/jurjen93/lofar_vlbi_polarization/blob/main/scripts/RMsynt.py

Comment thread scripts/run_rmtools.py
return parser.parse_args()

def stage_inputs(args: argparse.Namespace):
workdir = Path.cwd()

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add docstring

Comment thread scripts/run_rmtools.py
return cmd


def move_outputs(stokes_q_path: str) -> None:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this function being used? And why?
If not used: remove

Comment thread steps/wsclean_pol.cwl
prefix: '-name'
- id: scale
type: string?
default: "0.75asec"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be 0.075" if we are imaging at 0.3"

Comment thread steps/wsclean_pol.cwl
prefix: '-beam-size'
- id: taper-gaussian
type: string?
default: 1.2asec

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be much lower if we are imaging at 0.3" (I set it to 0.25")

Comment thread steps/wsclean_pol.cwl
prefix: '-taper-gaussian'
- id: niter
type: int
default: 150000

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be lower as there is not much to deconvolve in stokes Q and U

Comment thread steps/wsclean_pol.cwl
position: 1
shellQuote: false
prefix: '-niter'
- id: multiscale-scale-bias

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can and have to do multiscale cleaning for linear polarisation

id: image_polarization
label: Polarization imaging
doc: |
This workflow will image the provided MS in Q and U, and perform Rotation Measure Synthesis to provide linear polarization images.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add to the doc that this workflow is meant to feed with datasets of target sources, which are averaged to 32 seconds and XXX kHz (and with a phased-up Dutch core?)

@jurjen93

Copy link
Copy Markdown
Member

Other suggestion: split the imaging in imaging IV and QU separately, as they need different commands. The Stokes Q and U imaging also benefits from using a mask from the Stokes I image.
I have for example this bash command (which you can split in 3 CWL steps):
https://github.com/jurjen93/lofar_vlbi_polarization/blob/main/scripts/imaging_03.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants