Skip to content

fix(build): verify fixtures with two digests - #574

Open
LMLiam wants to merge 2 commits into
fix/issue-380/02-bounded-httpsfrom
fix/issue-380/03-dual-digest
Open

fix(build): verify fixtures with two digests#574
LMLiam wants to merge 2 commits into
fix/issue-380/02-bounded-httpsfrom
fix/issue-380/03-dual-digest

Conversation

@LMLiam

@LMLiam LMLiam commented Aug 16, 2026

Copy link
Copy Markdown
Owner

Summary

  • Require and stream-verify SHA-1 and SHA-256 for the fixture.
  • Add both digests to the cache key and verify both digests on restored cache entries.
  • Add deterministic cache-key tests and document the reviewed fixture baseline and update procedure.
  • Align the build-logic source path with its declared package.

Related issues

Closes #380

Type of change

  • fix: bug fix
  • test
  • docs
  • chore / build / ci

Testing

  • ./gradlew build --no-configuration-cache
  • ./gradlew :buildSrc:test --rerun-tasks --no-configuration-cache
  • ./gradlew :core:vanillaConformanceTest --rerun-tasks --no-configuration-cache
  • ./gradlew ktlintCheck spotlessCheck --no-configuration-cache
  • cd .github && npm run typecheck && npm run build && node --test actions/pr-metrics-comment/test/*.test.js scripts/*.test.js
  • actionlint .github/workflows/ci.yml
  • git diff --check

The live fixture matched SHA-1 823e2250d24b3ddac457a60c92a6a941943fcd6a and SHA-256 cdacdfb25898de5e4b4b0e5ddcc2722f77067e46605709c2d886c000ebb63ec5.

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 78eefc18-4d0d-4815-9490-8d5153a2bb63

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added type: docs Documentation changes area: build Build, CI, publishing, project structure labels Aug 16, 2026
@LMLiam LMLiam changed the title fix/issue 380/03 dual digest fix(build): verify fixtures with two digests Aug 16, 2026
@LMLiam LMLiam added type: bug Something is broken priority: high Needs urgent attention and removed type: docs Documentation changes labels Aug 16, 2026
@LMLiam
LMLiam force-pushed the fix/issue-380/03-dual-digest branch from ee592e7 to 17f8674 Compare August 17, 2026 12:30
@github-actions github-actions Bot added the type: docs Documentation changes label Aug 17, 2026
@LMLiam
LMLiam force-pushed the fix/issue-380/03-dual-digest branch from 17f8674 to f9b0fdb Compare August 17, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: build Build, CI, publishing, project structure priority: high Needs urgent attention type: bug Something is broken type: docs Documentation changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(build): harden verified fixture download and replacement

1 participant