fix(build): bound fixture HTTPS downloads - #573
Open
LMLiam wants to merge 1 commit into
Open
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
LMLiam
added
type: bug
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| "applies the byte limit when the length is absent or inaccurate" { | ||
| val exact = connection(status = 200, body = "1234", contentLength = null) |
| } | ||
|
|
||
| "applies the byte limit when the length is absent or inaccurate" { | ||
| val exact = connection(status = 200, body = "1234", contentLength = null) |
| BoundedHttpsDownload.download("https://fixture.test/file", ByteArrayOutputStream(), { exact }, 4, 3, 1, 2) | ||
| exact.disconnected shouldBe 1 | ||
|
|
||
| val oversized = connection(status = 200, body = "12345", contentLength = "1") |
| } | ||
| oversized.disconnected shouldBe 1 | ||
|
|
||
| val announcedOversize = connection(status = 200, body = "1", contentLength = "5") |
LMLiam
force-pushed
the
fix/issue-380/02-bounded-https
branch
from
August 17, 2026 12:30
6cd4f3d to
652c125
Compare
github-actions
Bot
removed
the
area: build
LMLiam
force-pushed
the
fix/issue-380/02-bounded-https
branch
from
August 17, 2026 12:47
652c125 to
0a77d42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issues
Part of #380
Type of change
Testing
./gradlew :buildSrc:test --rerun-tasks --no-configuration-cache./gradlew build --no-configuration-cacheactionlint .github/workflows/ci.ymlgit diff --check