Skip to content

Use shallow copy in _merge_sample_pair #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nightlessbaron wants to merge 2 commits into
base: prod
Choose a base branch
from
Open

Use shallow copy in _merge_sample_pair #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3935df
Use shallow copy in _merge_sample_pair; deepcopy of token lists made …
nightlessbaron Jul 3, 2026
2a6b456
Shallow-copy input sample per record; only mutated fields get fresh c…
nightlessbaron Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions miles/rollout/generate_utils/openai_endpoint_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import logging
import random
from argparse import Namespace
from copy import deepcopy
from copy import copy, deepcopy

from miles.rollout.generate_utils.generate_endpoint_utils import get_rollout_topk_from_response
from miles.rollout.session.session_types import GetSessionResponse, SessionRecord
Expand Down Expand Up @@ -184,7 +184,10 @@ def _compute_sample_from_openai_record(
output_token_ids = [item[1] for item in choice["meta_info"]["output_token_logprobs"]]
output_log_probs = [item[0] for item in choice["meta_info"]["output_token_logprobs"]]

sample = deepcopy(input_sample)
sample = copy(input_sample)
sample.metadata = dict(input_sample.metadata)
sample.weight_versions = list(input_sample.weight_versions)
sample.prefix_cache_info = deepcopy(input_sample.prefix_cache_info)
request_input_ids = record.request.get("input_ids")
if request_input_ids is not None:
assert (
Expand Down
4 changes: 2 additions & 2 deletions miles/rollout/generate_utils/sample_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from copy import deepcopy
from copy import copy
from dataclasses import fields

from miles.utils.types import Sample
Expand Down Expand Up @@ -30,7 +30,7 @@ def merge_samples(samples: list[Sample], tokenizer) -> Sample:

def _merge_sample_pair(a: Sample, b: Sample, tokenizer) -> Sample:
"""Merge two samples generated from sibling inference engine calls."""
a, b = deepcopy(a), deepcopy(b)
a, b = copy(a), copy(b)

def _merge_equal_value(field):
x = getattr(a, field)
Expand Down
Loading