Make session collection HTTP handling explicit and safe#66
Open
odp wants to merge 11 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made, sorted by importance:
Added Ray actor-based session servers, with multi-backend dispatch and clean shutdown.
Removed unnecessary response decoding/tokenization from sample construction and truncation;
sample.responseis now""andsample.metadata["response_decoded"] = False.Updated sample merging to respect
metadata["response_decoded"], avoiding decode unless responses were already decoded.Made session HTTP client more robust with
httpx, explicit timeouts, retries, backoff, better logging, and bounded collect concurrency.Compact session records returned by the session server to only include fields needed by the sample builder.
Moved sample construction and merge work into
asyncio.to_thread, and increased the async thread pool size.