Skip to content

fix(storage): allow digits in SQL table names and return errors instead of panicking - #2116

Open
AkramBitar wants to merge 1 commit into
mainfrom
issue-2034
Open

fix(storage): allow digits in SQL table names and return errors instead of panicking#2116
AkramBitar wants to merge 1 commit into
mainfrom
issue-2034

Conversation

@AkramBitar

@AkramBitar AkramBitar commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Fixes #2034

escapeForTableName omitted digits from its character allow-list and panicked on anything outside it, while buildTableNames formatted through MustFormat — so a channel name like channel1 crashed the node at store-construction time, with no recover() anywhere in the chain.

  • digits are now accepted, validated against the identifier actually emitted (prefix included);
  • unsupported characters return a configuration error instead of panicking.

Regression tests cover the real driver-construction and NewStoreServiceManager paths, not just the escaping helper, plus a FuzzGetTableNamesNoPanic target wired into the nightly fuzz matrix.

@AkramBitar AkramBitar added this to the Q3/26 milestone Aug 3, 2026
@AkramBitar AkramBitar self-assigned this Aug 3, 2026
…ad of panicking

Signed-off-by: Akram Bitar <akram@il.ibm.com>
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

📊 Token Validation Benchmark

Comparison of this PR against the base branch. 🟢 improvement · 🔴 regression · ➖ within ±1.0% noise.

Variant Benchmark Params Workers TPS (base → PR) Δ TPS
csp BenchmarkAPIGRPC f=1, nc=4, w=token-validation-service 4 118 → 117 ➖ -0.3%
csp BenchmarkLocalTokenValidation out-tokens=2in-tokens=2 4 104 → 104 ➖ +0.1%
ipa BenchmarkAPIGRPC f=1, nc=4, w=token-validation-service 4 70 → 70 ➖ -0.1%
ipa BenchmarkLocalTokenValidation out-tokens=2in-tokens=2 4 76 → 76 ➖ -0.0%

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

📊 Token Validation Benchmark

Comparison of this PR against the base branch. 🟢 improvement · 🔴 regression · ➖ within ±1.0% noise.

Variant Benchmark Params Workers TPS (base → PR) Δ TPS
csp BenchmarkAPIGRPC f=1, nc=4, w=token-validation-service 4 117 → 118 ➖ +0.3%
csp BenchmarkLocalTokenValidation out-tokens=2in-tokens=2 4 104 → 104 ➖ +0.2%
ipa BenchmarkAPIGRPC f=1, nc=4, w=token-validation-service 4 78 → 78 ➖ +0.2%
ipa BenchmarkLocalTokenValidation out-tokens=2in-tokens=2 4 79 → 79 ➖ -0.4%

@AkramBitar
AkramBitar requested review from SaidAltury-ibm and removed request for HayimShaul August 5, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

db: escapeForTableName panics on channel/network names containing digits

2 participants