fix(storage): allow digits in SQL table names and return errors instead of panicking - #2116
Open
AkramBitar wants to merge 1 commit into
Open
fix(storage): allow digits in SQL table names and return errors instead of panicking#2116AkramBitar wants to merge 1 commit into
AkramBitar wants to merge 1 commit into
Conversation
…ad of panicking Signed-off-by: Akram Bitar <akram@il.ibm.com>
📊 Token Validation BenchmarkComparison of this PR against the base branch. 🟢 improvement · 🔴 regression · ➖ within ±1.0% noise.
|
📊 Token Validation BenchmarkComparison of this PR against the base branch. 🟢 improvement · 🔴 regression · ➖ within ±1.0% noise.
|
AkramBitar
requested review from
SaidAltury-ibm
and removed request for
HayimShaul
August 5, 2026 14:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2034
escapeForTableNameomitted digits from its character allow-list and panicked on anything outside it, whilebuildTableNamesformatted throughMustFormat— so a channel name likechannel1crashed the node at store-construction time, with norecover()anywhere in the chain.Regression tests cover the real driver-construction and
NewStoreServiceManagerpaths, not just the escaping helper, plus aFuzzGetTableNamesNoPanictarget wired into the nightly fuzz matrix.