fix setConfSetting for non-integer values#43
Open
WSaffery wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
setConfSettingwill not work if the user tries to set a value that is not a string.This patch fixes that.
Edit: I'll also note it may be the case that the eval based functionality in this library doesn't work with Python 3.13, although I'm not entirely sure, it's just the only explanation I have for some behaviour I've observed. Not relevant to this request though, just a heads up.
Edit2: Just saw the function is deprecated, I got the wrong idea that it was required from
Example.py, I'll update it to use the dict setting approach.