More fixes for sbase and ubase#275
Merged
Merged
Conversation
….sh to allow compability with ubase
ubase umount does not have `--lazy` flag.
…is avoids issues with tar implementations that lacks gzip support
…ith tar implementations without support for gzip/bzip2
Kron4ek
reviewed
Jun 11, 2026
|
|
||
| # If the previous download failed, get the URL from FlatHub repo | ||
| if [ ! -s nvidia.run ] || [[ "$(stat -c%s nvidia.run)" -lt 30000000 ]]; then | ||
| if [ ! -s nvidia.run ] || [[ "$(stat nvidia.run | grep Size | awk -F ' ' '{print $2}')" -lt 30000000 ]]; then |
Owner
There was a problem hiding this comment.
This is not needed, because this function (nvidia_driver_handler) is executed inside the container. Better to not change this line.
Kron4ek
reviewed
Jun 11, 2026
| busybox_size=1181592 | ||
| utils_size=4393102 | ||
|
|
||
|
|
Contributor
Author
|
Fixed and pushed. Thanks for pointing that out. |
this also made it impossible to include utils, because stat would just error out, thus deactivating their inclusion into conty.
… use all cores/threads, unless otherwise specified. Users might also already have set MAKEFLAGS on their system, and using nproc in this manner will override this. also; sbase/ubase does not have nproc command
…CXX to clang if avilable instead of forcing it
hovercats
added a commit
to hovercats/Conty
that referenced
this pull request
Jun 12, 2026
* enter-chroot.sh: follow the same mount flags as create-arch-bootstrap.sh to allow compability with ubase * mounting /dev twice is redundant * enter-chroot.sh: ubase umount does not have -R flag. * conty-start.sh: use `-l` flag when lazy unmounting. ubase umount does not have `--lazy` flag. * workaround leftover `sed -i` usage I missed earlier * create-conty.sh: pipe gzip into tar when unpacking utils tarballs. this avoids issues with tar implementations that lacks gzip support * create-utils.sh: split tar usage for gzip and bzip2 to avoid issues with tar implementations without support for gzip/bzip2 * be consistent about how we unmount $bootstrap * add bootstrap tarball and sha256sums.txt to .gitignore * workaround for `stat -c` flag. sbase stat does not have this flag. this also made it impossible to include utils, because stat would just error out, thus deactivating their inclusion into conty. * using nproc is not neccessary when calling make, make will by default use all cores/threads, unless otherwise specified. Users might also already have set MAKEFLAGS on their system, and using nproc in this manner will override this. also; sbase/ubase does not have nproc command * clang might not be available on all systems, make a switch to set CC/CXX to clang if avilable instead of forcing it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on my last PR. sbase/ubase users (and oasis linux, such as myself), should with this PR be able to build a conty image too.
Let me know if theres anything you dont like here.