Skip to content

fix(runner): stop marking routine system messages as failed steps - #147

Merged
KrisPowers merged 2 commits into
mainfrom
fix/system-step-false-failure
Jul 28, 2026
Merged

fix(runner): stop marking routine system messages as failed steps#147
KrisPowers merged 2 commits into
mainfrom
fix/system-step-false-failure

Conversation

@KrisPowers

@KrisPowers KrisPowers commented Jul 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • emit_system_line hardcoded every synthetic "system" step to status failed with exit code -1, even for routine progress notes like the post-checkout and sandbox-ready messages, so a successful checkout showed up as a failed stage on the run detail page while the job and run kept going normally (job/run status is tracked independently of this synthetic step).
  • Callers now pass whether the message represents an actual failure, so success notes record as succeeded and only genuine failures record as failed.

Test plan

  • cargo check on the backend crate
  • Push a commit and confirm the run detail page's "system" stage now shows succeeded instead of failed for a normal checkout

Wraps the workflow list in the same bordered/rounded card treatment
used by recent activity, aligns the two column headers to the same
height, and clips list rows to the card's rounded corners so selected
rows don't square off past the border.
emit_system_line hardcoded every synthetic system step to status
failed/exit -1, even for progress notes like the post-checkout and
sandbox-ready lines. That made the run detail page show a failed
system stage on every successful run. Callers now pass whether the
message represents an actual failure.
@KrisPowers
KrisPowers force-pushed the fix/system-step-false-failure branch from 6e1bc6b to c069d0d Compare July 28, 2026 02:50
@KrisPowers
KrisPowers merged commit b366d01 into main Jul 28, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant