fix(ci): use fresh viewer artifact for browser contracts by KooshaPari · Pull Request #541 · KooshaPari/SessionLedger

KooshaPari · 2026-08-25T10:04:02Z

User description

Summary

avoid dx 0.7.9 release wasm-opt SIGABRT in qgate and accessibility workflows
build a fresh debug web artifact with debug symbols disabled
prevent Playwright from silently exercising stale release output

Evidence

The post-merge main run 32825796427 logged wasm-opt failed with status code signal: 6 (SIGABRT) before the browser suite reported the same historical visual failures. The equivalent non-release build completed successfully locally at /tmp/sessionledger-dx-debug-20260825b.

Validation

actionlint qgate/a11y
git diff --check

CodeAnt-AI Description

Ensure browser contract checks use a fresh web build when release optimization fails

What Changed

Accessibility and browser contract workflows now build a fresh debug web artifact without debug symbols instead of using release builds that can abort during optimization
Browser tests no longer risk running against stale output after a failed web build

Impact

✅ Fewer CI failures from web build optimization
✅ Browser tests validate the current source
✅ More reliable accessibility and visual checks

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

codeant-ai · 2026-08-25T10:04:07Z

🤖 CodeAnt AI — Review Status

Status	Commit	Started (UTC)	Finished (UTC)
✅ Reviewed your PR	`10f589c`	Aug 25, 2026 · 10:04	10:04

codeant-ai · 2026-08-25T10:04:08Z

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

coderabbitai · 2026-08-25T10:05:14Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a6daf2d1-7830-4fed-b681-ab4d12a01c63

📥 Commits

Reviewing files that changed from the base of the PR and between 75fe195 and 10f589c.

📒 Files selected for processing (2)

.github/workflows/a11y.yml
.github/workflows/qgate.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout. (23)

GitHub Check: Cargo Deny (Advisories + Licenses)
GitHub Check: sl-daemon · repository builder image offline build / sl-daemon · repository builder image offline build
GitHub Check: sl-daemon · locked offline build
GitHub Check: prepare
GitHub Check: load macro gate · macro routes smoke
GitHub Check: visual contract · WCAG AA
GitHub Check: jemalloc default-on · unix default build
GitHub Check: shuttle permutation · cargo test shuttle_permutation
GitHub Check: loom permutation · daemon broadcast
GitHub Check: cargo audit
GitHub Check: sl-viewer macOS app · artifact
GitHub Check: jemalloc default-on · windows default build
GitHub Check: loom permutation · core models
GitHub Check: Pull secrets from Infisical
GitHub Check: soft loom · daemon broadcast
GitHub Check: soft loom · loom_model core
GitHub Check: soft loom · daemon mpsc
GitHub Check: update check hard · sl-daemon tests
GitHub Check: sl-viewer help · unit tests
GitHub Check: Kilo Code Review
GitHub Check: semgrep-cloud-platform/scan
GitHub Check: Summary
GitHub Check: prepare

⚠️ CI failures not shown inline (1)

GitHub Check: Rule: Request review from team (request_reviews): Invalid requested teams

Conclusion: failure

View job details

In the rule `Request review from team`, the action `request_reviews` configuration is invalid:
Invalid requested teams
Team `phenotype/core` is not part of the organization `KooshaPari`

🧰 Additional context used

🪛 zizmor (1.29.0)

.github/workflows/a11y.yml

[warning] 1-54: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block

(excessive-permissions)

[warning] 13-54: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block

(excessive-permissions)

🔇 Additional comments (2)

.github/workflows/a11y.yml (1)

34-36: LGTM!

.github/workflows/qgate.yml (1)

127-131: LGTM!

📝 Walkthrough

Summary

This PR updates the qgate and accessibility workflows to avoid wasm-opt SIGABRT failures from dx 0.7.9.

The workflows now build fresh debug web artifacts with debug symbols disabled. This prevents Playwright from testing stale release output after a failed wasm-opt step.

Must Fix

None identified.

Should Fix

None identified.

Consider

The workflows no longer validate the release build path. Add a separate release-build check after the dx/Binaryen issue is resolved.

Approve / Request Changes

Approve. The CI-only changes are focused and address the reported failure.

Walkthrough

The accessibility and browser end-to-end workflows now build the Dioxus web surface in debug mode. The accessibility build disables debug symbols. The browser end-to-end workflow documents the release wasm-opt failure.

Changes

CI web build mode

Layer / File(s)	Summary
Switch CI web builds to debug artifacts `.github/workflows/a11y.yml`, `.github/workflows/qgate.yml`	Both workflows remove the release build. The accessibility workflow disables debug symbols. The browser end-to-end workflow documents the Binaryen `wasm-opt` abort and stale-artifact concern.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 10f58

The workflows now build a fresh debug web artifact for browser checks, reducing the chance of stale or optimization-failed output being tested; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main CI change: using a fresh viewer artifact for browser contract checks.
Description check	✅ Passed	The description directly explains the CI changes, the wasm-opt failure, the stale artifact risk, and the validation performed.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/visual-build-no-wasm-opt-20260825

✨ Simplify code

Create PR with simplified code
Commit simplified code in branch fix/visual-build-no-wasm-opt-20260825

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

mergify · 2026-08-25T10:07:30Z

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

Queue this pull request

kilo-code-bot · 2026-08-25T10:55:06Z

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)

.github/workflows/a11y.yml - Updated dx build command to avoid wasm-opt SIGABRT
.github/workflows/qgate.yml - Updated dx build command and comment to reflect debug build approach

_{Reviewed by free · Input: 47.1K · Output: 8.5K · Cached: 206.8K}

fix(ci): avoid stale viewer artifact after wasm-opt abort

10f589c

Copilot AI lite review requested due to automatic review settings August 25, 2026 10:04

Copilot AI reviewed Aug 25, 2026

codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Aug 25, 2026

coderabbitai Bot approved these changes Aug 25, 2026

View reviewed changes

Navigation Menu

fix(ci): use fresh viewer artifact for browser contracts - #541

fix(ci): use fresh viewer artifact for browser contracts#541
KooshaPari wants to merge 1 commit into
mainfrom
fix/visual-build-no-wasm-opt-20260825

KooshaPari commented Aug 25, 2026 •

edited by codeant-ai Bot

Loading

Uh oh!

codeant-ai Bot commented Aug 25, 2026 •

edited

Loading

Uh oh!

codeant-ai Bot commented Aug 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

coderabbitai Bot commented Aug 25, 2026 •

edited

Loading

Summary

Must Fix

Should Fix

Consider

Approve / Request Changes

Walkthrough

Changes

Uh oh!

mergify Bot commented Aug 25, 2026

Uh oh!

kilo-code-bot Bot commented Aug 25, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

KooshaPari commented Aug 25, 2026 • edited by codeant-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

Summary

Evidence

Validation

CodeAnt-AI Description

What Changed

Impact

Checking Your Pull Request

Talking to CodeAnt AI

Example

Preserve Org Learnings with CodeAnt

Example

Retrigger review

Check Your Repository Health

Uh oh!

codeant-ai Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 CodeAnt AI — Review Status

Uh oh!

codeant-ai Bot commented Aug 25, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Must Fix

Should Fix

Consider

Approve / Request Changes

Walkthrough

Changes

Uh oh!

mergify Bot commented Aug 25, 2026

Uh oh!

kilo-code-bot Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

KooshaPari commented Aug 25, 2026 •

edited by codeant-ai Bot

Loading

codeant-ai Bot commented Aug 25, 2026 •

edited

Loading

coderabbitai Bot commented Aug 25, 2026 •

edited

Loading

kilo-code-bot Bot commented Aug 25, 2026 •

edited

Loading