test(viewer): settings_tab HealthStatus proptest surface (WBS-6.2 #456) - #468
test(viewer): settings_tab HealthStatus proptest surface (WBS-6.2 #456)#468KooshaPari wants to merge 4 commits into
Conversation
Adds crates/sl-viewer/tests/properties_viewer_mock_data.rs with 18
proptest properties pinning the deterministic demo fixtures:
* sample_bundles():
* Non-empty, returns the documented 3-entry sample.
* Every source_id is non-empty and unique.
* Every ContinuationBundle has at least one Bundle slice, at
least one Intent slice, and an Intent with a non-empty goal.
* Every Acceptance slice carries ready: true.
* Deterministic across calls.
* sample_sessions():
* Non-empty, returns the documented 3-entry sample.
* Every session id is non-empty and unique.
* Every session has at least one non-empty-content message.
* Every session has non-empty cwd and title.
* Every session contains at least one User and one Assistant
message so the timeline UI can render both sides.
* Deterministic across calls.
Updates WBS-6.2 evidence list, TRACEABILITY.json, and CHANGELOG.
Adds two complementary property surfaces for sl-viewer's pure
data-reducers:
* crates/sl-viewer/tests/properties_viewer_theme.rs (28 props):
- Theme::default() is System; JSON round-trips for every variant.
- ThemeColors::dark and ThemeColors::light each expose 9 fields
that all match the documented lab_coat::* constants; every
field is non-empty; focus == accent for both palettes.
- for_theme(Dark|Light|System) is the documented palette.
* crates/sl-viewer/tests/properties_viewer_settings.rs (21 props):
- DefaultTab::default() is Bundles; ALL covers every variant,
length 9, every tab_id/value_attr unique kebab-case ASCII.
- Settings::default() matches documented; JSON round-trips;
serialised theme is lowercase, default_tab is kebab-case.
- save_to_path / load_from_path round-trip; missing/corrupt
files fall back to default(); parent dirs created.
- resolve_settings_dir honours overrides; falls through on
empty; picks documented macOS / Windows / Linux paths.
Updates WBS-6.2 evidence list, TRACEABILITY.json, and CHANGELOG.
Adds crates/sl-viewer/tests/properties_viewer_help_overlay.rs with 13 proptest properties pinning the keyboard help SSOT: * SHORTCUTS is non-empty. * Every shortcut has non-empty keys / scope / action. * Every action is descriptive (has at least one ASCII letter) and human-readable (no ERR_ / error code leaks). * Every (keys, scope) pair is unique so the rendered table does not collide on its React key. * The ?, Escape, and Cmd+K / Ctrl+K shortcuts are present. * Every scope is one of the documented panel scopes. * Every keys is non-blank. Updates WBS-6.2 evidence list, TRACEABILITY.json, and CHANGELOG.
Adds crates/sl-viewer/tests/properties_viewer_settings_tab.rs with 11 proptest properties pinning the settings tab SSOT: * HealthStatus::Unknown.label() is , Healthy is , Unreachable is . * Every label is non-empty, distinct across variants, single-line, and lowercase ASCII. * label() is deterministic across calls. * THEME_RADIO_GROUP_ID is non-empty, kebab-case ASCII, and distinct from FORGE_DB_HINT_STORAGE_KEY. Updates WBS-6.2 evidence list, TRACEABILITY.json, and CHANGELOG.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reached
Next review available in: 32 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
codeant-ai
Bot
added
the
size:XL
|
Closing due to merge conflicts. |
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| let default_tab = DefaultTab::ALL[default_tab_idx]; | ||
| let s = Settings { theme, default_tab }; | ||
| let json = serde_json::to_string(&s).expect("serialize"); | ||
| let back: Settings = serde_json::from_str(&json).expect("deserialize"); | ||
| prop_assert_eq!(back, s); |
There was a problem hiding this comment.
Suggestion: The round-trip property only serializes complete Settings values, despite the documented contract explicitly including partial fields. It would still pass if deserialization stopped accepting JSON with either theme or default_tab omitted, so backward compatibility for existing partial settings files is not actually covered. Add cases for each missing field and assert the serde defaults. [incomplete implementation]
Severity Level: Major ⚠️
- ⚠️ Partial settings-file compatibility is untested.
- ❌ Older or hand-edited files could reset unexpectedly.
- ⚠️ Viewer startup preferences may change after upgrades.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** crates/sl-viewer/tests/properties_viewer_settings.rs
**Line:** 144:148
**Comment:**
*Incomplete Implementation: The round-trip property only serializes complete `Settings` values, despite the documented contract explicitly including partial fields. It would still pass if deserialization stopped accepting JSON with either `theme` or `default_tab` omitted, so backward compatibility for existing partial settings files is not actually covered. Add cases for each missing field and assert the serde defaults.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix| fn resolve_settings_dir( | ||
| override_dir: Option<&str>, | ||
| home: Option<&OsStr>, | ||
| appdata: Option<&OsStr>, | ||
| xdg_config: Option<&OsStr>, | ||
| ) -> Option<PathBuf> { | ||
| if let Some(dir) = override_dir { |
There was a problem hiding this comment.
Suggestion: The resolver properties exercise a private resolver reimplemented inside the test rather than settings.rs::resolve_settings_dir, so they can continue passing after the production resolver changes. Expose the production helper under a test-compatible interface or move these tests into the settings module so they execute the actual implementation. [incomplete implementation]
Severity Level: Major ⚠️
- ⚠️ Platform resolver regressions can evade these properties.
- ❌ Settings may load from the wrong OS-specific directory.
- ⚠️ Persisted viewer preferences may appear missing.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** crates/sl-viewer/tests/properties_viewer_settings.rs
**Line:** 347:353
**Comment:**
*Incomplete Implementation: The resolver properties exercise a private resolver reimplemented inside the test rather than `settings.rs::resolve_settings_dir`, so they can continue passing after the production resolver changes. Expose the production helper under a test-compatible interface or move these tests into the settings module so they execute the actual implementation.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| // appear under multiple scopes (e.g. `Escape` is a multi-scope | ||
| // close). We assert that at least one key appears more than once | ||
| // is reasonable; the strong check is the (keys, scope) pair. | ||
| let _ = (keys.len(), SHORTCUTS.len()); |
There was a problem hiding this comment.
SUGGESTION: shortcuts_keys_unique is a no-op — it deduplicates keys but never asserts the result
The test collects all keys, sorts and deduplicates them, then discards the result with let _ = .... It would pass even if every shortcut shared the same key. Either remove this test (the (keys, scope) pair uniqueness at line 82 is the strong check) or add an assertion that validates the claim in the doc comment.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (4 files)
Fix these issues in Kilo Cloud Reviewed by step-3.7-flash · Input: 98.8K · Output: 16.5K · Cached: 432.1K |
User description
Summary
Adds
crates/sl-viewer/tests/properties_viewer_settings_tab.rswith 11 proptest properties pinning thesettings_tab::HealthStatusenum andTHEME_RADIO_GROUP_IDSSOT (WBS-6.2 #456).HealthStatus(8 properties)Unknown/Healthy/Unreachablelabel()values match the documented strings.label()is deterministic across calls.THEME_RADIO_GROUP_ID(3 properties)FORGE_DB_HINT_STORAGE_KEY.Validation
cargo test -p sl-viewer --test properties_viewer_settings_tab --features "desktop parquet" --locked— 11 passedcargo fmt --all --check— cleanWBS / TRACEABILITY
WBS-6.2 evidence list and
TRACEABILITY.jsongaincrates/sl-viewer/tests/properties_viewer_settings_tab.rs. CHANGELOG Unreleased documents the new surface.CodeAnt-AI Description
Add property coverage for sl-viewer settings, themes, shortcuts, and health labels
What Changed
Impact
✅ Safer viewer preference persistence✅ Fewer theme and tab configuration regressions✅ Consistent keyboard help and settings UI labels💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.