Remove disabled meta cache refresh setup#105
Open
kingpy-bot wants to merge 1 commit into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThis change removes dead code related to a disabled meta cache refresh background task. It deletes ChangesDead Meta Cache Refresh Removal
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This removes the disabled meta cache refresh setup path from the API.
The previous startup path called
setup(...), thenmeta::setup(...), thenguilds::setup(...), which logged that a meta cache refresh task was spawning. The actual task was permanently guarded behindif false, so no background refresh could run. This patch removes that unreachable setup path and the now-unused imports/helpers around it.Closes #33.
Scope
refresh_meta_cache(...)loop.tokio::timesleep./meta/guildsand/meta/guilds/{guild_id}handlers unchanged.Local checks
git -c core.whitespace=trailing-space,space-before-tab,cr-at-eol diff --check HEAD~1..HEAD: passNot run locally:
cargo check -p apiandcargo fmt --check, because this host does not havecargo/rustfmtinstalled. CI or a Rust-equipped environment should confirm before merge.AI-assisted disclosure: I used an AI coding agent to prepare this cleanup patch and validation notes.
Summary by CodeRabbit
Refactor
Bug Fixes