Use the current template reference in the configuration example - #507
Open
Amoifr wants to merge 1 commit into
Open
Use the current template reference in the configuration example#507Amoifr wants to merge 1 commit into
Amoifr wants to merge 1 commit into
Conversation
garak
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #504.
The section says the block lists the default configuration, but the template it shows is neither the default nor resolvable.
Configuration.phpalready defaults to@KnpMenu/menu.html.twig, andKnpMenuExtensionTestasserts it:The documented
KnpMenuBundle::menu.html.twigis wrong twice over. TheBundle::templatesyntax was deprecated in Symfony 4.4 and removed in 5.0, so this has been broken for longer than the report suggests, and even under the old syntax it resolved toResources/views/, while the template has since moved totemplates/menu.html.twig.@vpassama reported the YAML block. The same value appears in the XML and PHP blocks of the same
configuration-block, so all three are updated. The YAML one needs quotes, since an unquoted@starts a reserved indicator and the file would no longer parse.I left the rest of the section alone, including the
loadFromExtension()style of the PHP block, to keep this to the reported problem.