fix(search): fall back to TSV when gum table rejects input (#148)#149
Open
olavostauros wants to merge 1 commit into
Open
fix(search): fall back to TSV when gum table rejects input (#148)#149olavostauros wants to merge 1 commit into
olavostauros wants to merge 1 commit into
Conversation
…kLabs#148) Sanitize cell values (tabs→spaces, newlines→⏎) and wrap gum table call in try/except to fall back to plain TSV on failure. Apply same fix to notes list. Add test for unusual-character input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When note titles, body snippets, or metadata contain characters that
gum tablecannot parse (tabs, newlines),notes searchcrasheswith
CalledProcessError. This is a presentation-only failure — thesearch results are correct. The same bug affects
notes list.Changes
before passing data to gum.
as plain tab-separated text instead of crashing.
--jsonoutput is unaffected (bypasses gum entirely)..mise/tasks/list(identical gum table pattern).Design decisions
gum⏎is acceptable;--jsonis the contract for machine consumptionpython3 -cheredoc for reliable literal tab characterValidation
bats test/search.bats— all 6 tests pass (1 new)bats test/list.bats— all 13 tests passgit diff --checkCloses #148