Update main.js#1
Open
AlionaTytarenko wants to merge 17 commits into
Open
Conversation
Kirill380
reviewed
Dec 5, 2019
Kirill380
reviewed
Dec 11, 2019
| sumShift = (centuryShift + yearShift + monthShift + dayShift); | ||
| dayOfWeek = Math.round(sumShift/7); | ||
|
|
||
| if (dayOfWeek == 1) { |
Owner
There was a problem hiding this comment.
use array for getting the name of day of week by index
|
|
||
| yearShift = ((decimalYear + (decimalYear/4)) % 7); | ||
|
|
||
| if ([01, 10].includes(month)) { |
Owner
There was a problem hiding this comment.
use array for getting the shift of month by index
Kirill380
reviewed
Dec 14, 2019
| // https://artofmemory.com/blog/how-to-calculate-the-day-of-the-week-4203.html | ||
| // https://wpcalc.com/kak-uznat-den-nedeli-lyuboj-daty/ | ||
|
|
||
| if (!date || date.length == 0) { |
| let monthNumber = Number(arr[1]); | ||
| let yearNumber = Number(arr[2]); | ||
|
|
||
| if (Number(dayNumber) != Number(dayNumber) || dayNumber != dayNumber || dayNumber < 0 || dayNumber > 31 || dayNumber == null || dayNumber == Infinity || dayNumber == -Infinity || dayNumber == 0) { |
Owner
There was a problem hiding this comment.
move checks only related to number to a separate function, give it a name isNumber()
| if (Number(dayNumber) != Number(dayNumber) || dayNumber != dayNumber || dayNumber < 0 || dayNumber > 31 || dayNumber == null || dayNumber == Infinity || dayNumber == -Infinity || dayNumber == 0) { | ||
| throw new Error('Invalid value of day') | ||
| }; | ||
| if (Number(monthNumber) != Number(monthNumber) || monthNumber != monthNumber || monthNumber < 0 || monthNumber > 12 || monthNumber == null || monthNumber == Infinity || monthNumber == -Infinity || monthNumber == 0) { |
| if (Number(monthNumber) != Number(monthNumber) || monthNumber != monthNumber || monthNumber < 0 || monthNumber > 12 || monthNumber == null || monthNumber == Infinity || monthNumber == -Infinity || monthNumber == 0) { | ||
| throw new Error('Invalid value of month') | ||
| }; | ||
| if (Number(yearNumber) != Number(yearNumber) || yearNumber != yearNumber || yearNumber < 0 || yearNumber == null || yearNumber == Infinity || yearNumber == -Infinity || yearNumber == 0) { |
| alert (yyyy); | ||
| }; | ||
| yyyy++ | ||
| } while (yyyy !== 2002); No newline at end of file |
Author
There was a problem hiding this comment.
oops, changed it just for fast debugging
| } | ||
|
|
||
| for (let i = 0; | ||
| i < dateInvalidValue.length; i++) { |
Owner
There was a problem hiding this comment.
should be on the same line with initialization of i (let i = 0), i is code style convention
Author
There was a problem hiding this comment.
... remember you were trying to beautify markup? it wasnt me who was trying ;)
| }); | ||
| } | ||
|
|
||
| for (let i = 0; |
Owner
There was a problem hiding this comment.
you don't need a loop for only one value
| } | ||
|
|
||
|
|
||
| let dayInvalidValue = ['12,2.01.1234', '32.2.00', ' ', '0.-.=']; |
Owner
There was a problem hiding this comment.
I read the mocha documentation and found a more easier and shorter way to write parameterized tests (actualy I can figure out by my own):
['12,2.01.1234', '32.2.00', ' ', '0.-.='].forEach(x => {
it(`${x} throws exception`, function() {
assert.throws(() => dayOfWeek(x), 'Invalid value of day');
});
})
Author
There was a problem hiding this comment.
Im not sure I did this properly, tests broke down after my fix(
Kirill380
reviewed
Dec 14, 2019
|
|
||
| function getDate(dd,mm,yyyy) {return `${dd}.${mm}.${yyyy}`} | ||
|
|
||
| yyyy = 1997; |
Kirill380
reviewed
Dec 14, 2019
|
|
||
| yyyy = 1997; | ||
| do { | ||
| dayOfWeek(getDate(13,07,yyyy)); |
JUST APPROVE!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.