Implement fill_single_element_interpolation_matrix!() for Chebyshev - #460
Merged
Conversation
The current implementation of fill_single_element_interpolation_matrix!() does not actully require the discretization_info, so could use a single implmentation covering both gausslegendre_pseudospectral and chebyshev_pseudospectral, but not sure if this will always be true, and it is only a small function so having two identical copies for now is not a big problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of
fill_single_element_interpolation_matrix!()does not actully require the discretization_info, so could use a single implmentation covering both gausslegendre_pseudospectral and chebyshev_pseudospectral, but not sure if this will always be true, and it is only a small function so having two identical copies for now is not a big problem.Tests are only failing due to a bug in the latest versions of TimerOutputs.jl, which will be fixed soon (KristofferC/TimerOutputs.jl#239).