Refactor boundary flags - #2
Merged
Merged
Conversation
…oundary_condition` to permit cylindrical coordinates (r,z) where the r=0 is included on the grid but no boundary condition is imposed at r=0.
…igin, but no boundary condition is imposed there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the flags controlling boundary conditions, by adding
permitting the user to include boundary points and also not impose a boundary condition there. This is useful in the case of cylindrical coordinates, where we may wish to define a coordinate on
[0,L]and only impose boundary conditions atL. The previous implementation would require the use of points(0,L]to achieve the same outcome.Use this feature on
[0,L]by writingas compared to the option for
(0,L]below.