fix: apply asset policy to audio beds - #155
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Applies the configured asset URL policy to composition audio-bed sources in validation and runtime playback, so hardened deployments can use the same base URL and scheme allowlist for scene assets and composition beds.
Requirement UIDs
Related Issues
Closes #148
ADR Impact
Changes
AssetUrlPolicycontract used by validation, preloading, and audio checks.audioBed.srcentries throughresolveAssetUrl()with the configuredbaseUrlandallowedSchemes.createAudioService()and the scene loader so bed playback is rejected at runtime if validation was skipped.audioBed.srctests for validation and runtime policy enforcement, plus default permissive-policy coverage.Test Plan
Unit tests pass (
make test)Integration tests pass if applicable (
make integration)make checkpasses (Spotless, SpotBugs, Error Prone, Checkstyle, JaCoCo)No coverage regression
pnpm test -- tests/runtime/validation.test.ts tests/runtime/audio.test.ts tests/runtime/scene-loader-audio.test.tspnpm test -- tests/runtime/audio.test.ts tests/runtime/validation.test.ts tests/runtime/scene-loader-audio.test.tspnpm lint && pnpm typecheck && pnpm testpre-commit run --all-filesGround Control Checks
make policypassesgc_evaluate_quality_gatespasses or is unchanged by this repo-only changegc_run_sweepreviewed; findings fixed or recorded with rationaleTraceability
Checklist
docs/CODING_STANDARDS.md)@Auditedon new entities if applicablechangelog.d/148.fixed.md