Skip to content

fix: preserve audio beds in head slices - #154

Merged
Brad-Edwards merged 1 commit into
devfrom
147-preserve-audio-beds
May 23, 2026
Merged

fix: preserve audio beds in head slices#154
Brad-Edwards merged 1 commit into
devfrom
147-preserve-audio-beds

Conversation

@Brad-Edwards

Copy link
Copy Markdown
Contributor

Summary

Preserves composition audio-bed metadata when composition slices are truncated to their addressed head scene, so loop and scrub modes keep the declared bed while standalone remains explicitly suppressed.

Requirement UIDs

  • (none — bug/refactor/maintenance run; see Traceability section below)

Related Issues

Closes #147

ADR Impact

  • ADR-004
  • ADR-017
  • ADR-018
  • ADR-020
  • ADR-021

Changes

  • Carry audioBed through the loader's head-only composition slice rebuild.
  • Carry audioBed through the direct scene-navigation bridge head truncation path.
  • Add loader regression coverage proving loop and scrub head slices construct and start the composition bed, while existing standalone suppression remains intact.
  • Tighten the prompter audio bypass test so a lifecycle regression cannot be masked by an empty audio allowlist.

Test Plan

  • Unit tests pass (make test)

  • Integration tests pass if applicable (make integration)

  • make check passes (Spotless, SpotBugs, Error Prone, Checkstyle, JaCoCo)

  • No coverage regression

  • pnpm test -- tests/runtime/scene-loader-audio.test.ts

  • pnpm test -- tests/runtime/scene-loader-audio.test.ts tests/runtime/scene-navigation.test.ts

  • pnpm lint && pnpm typecheck && pnpm test

  • pre-commit run --all-files

Ground Control Checks

  • make policy passes
  • gc_evaluate_quality_gates passes or is unchanged by this repo-only change
  • gc_run_sweep reviewed; findings fixed or recorded with rationale

Traceability

Checklist

  • Code follows project coding standards (docs/CODING_STANDARDS.md)
  • No business logic in API layer
  • Domain layer has no framework imports
  • Envers @Audited on new entities if applicable
  • Changelog fragment added at changelog.d/147.fixed.md
  • Architectural docs updated if stack, package structure, or key behaviors changed

@sonarqubecloud

Copy link
Copy Markdown

@Brad-Edwards
Brad-Edwards merged commit 829ca51 into dev May 23, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant