feat(tv): stagger + virtualize thumbnail loading#143
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EnhE6P81JhB2ePneazHwMi
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EnhE6P81JhB2ePneazHwMi
- capHlsLevel: also mutate el.api.config buffer fields alongside autoLevelCapping; hlsConfigFor caches at first render (always level 0), so buffer caps never reached higher tiers at runtime without this - priorityIds: pass [] in multiSelectMode — selected players render title- only (no <ReactPlayer>) so they would never call markLoaded and would permanently occupy concurrency slots, starving strip thumbnails - recompute: union priorityIds into effective visible set so the focused channel stays mounted even if its thumbnail scrolls out of the strip - TV.module.scss: update stale comment (players are now unmounted off-screen) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EnhE6P81JhB2ePneazHwMi
8a7334e to
b0be7f6
Compare
robbiebyrd
pushed a commit
that referenced
this pull request
Jun 25, 2026
Removes stagger/IntersectionObserver loading (PR #143 — Safari unstable). Each thumbnail is now a static <img> refreshed every 4 s via thumbTick and served from thumbnails/{slug}.jpg on Wasabi. Falls back to thumbnails/offline.jpg on error (onError handler). Also reverts the capHlsLevel buffer-cap mutation and bufferCapsForLevel spread in hlsConfigFor that were added as part of the stagger work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deviceMemory→hardwareConcurrency/2→ 4, clamped to [2,8]). Below 4 channels, mounts everything with no queue.capHlsLevelalongside the existing ABR ceiling.Files
staggerLoad.tscomputeConcurrency,reconcile,markLoaded,shouldMount,bufferCapsForLeveluseStaggeredLoad.tsTV.tsxstripRef,priorityIds,channelIds, gateshouldMount,markLoadedinonReady, buffer caps viacapHlsLevelBugs caught and fixed during review
hlsConfigForcaches config on first render (all players at level 0), so buffer tiers were never reachable. Fixed:capHlsLevelnow mutatesel.api.config.{maxBufferLength,backBufferLength,maxBufferSize}at runtime alongsideautoLevelCapping.priorityIds = selectedPlayersin grid mode caused selected channels (which render title-only, never mounting a<ReactPlayer>) to permanently occupy concurrency slots. Fixed:priorityIds = []inmultiSelectMode.Test plan
npx vitest runinpackages/frontend→ 179/179 passingStacked on
PR #142 (
feat/tv-graceful-quality) — base isfeat/tv-graceful-quality, notmain. Merge #142 first, then this.🤖 Generated with Claude Code
https://claude.ai/code/session_01EnhE6P81JhB2ePneazHwMi