BE-6875 Additional changes to ingest KD folder data#135
BE-6875 Additional changes to ingest KD folder data#135hleekeeper merged 2 commits intofeature-kd-v1from
Conversation
hleekeeper
requested review from
THeflinKeeper,
saldoukhov and
tylerccarson
as code owners
| parentKind: 'keeper_drive_folder', | ||
| childKind: 'record', | ||
| childUid: recordUid, | ||
| }) |
There was a problem hiding this comment.
❓ Why do we need this?
When a KD folder is removed, all its child resources should be wiped altogether. However, since the delete operation takes place before the dependency removal, when the record is removed from the folder, the folder data is already cleaned up and the consumer app fails to identify the kind based off of the uid. This will remove the burden of consumer apps figuring out the resource type out of the uid.
There was a problem hiding this comment.
I think this is such a good idea that it's maybe worth making this a breaking change (rather than string | RemovedDependency, make children just a set of RemovedDependency). The guessing we have to do on the BE side is no fun and probably caused some bugs. Something to consider (of course all the other dependency additions would have to be updated)
There was a problem hiding this comment.
yeah just wanted to avoid big changes. I'll create a Jira ticket for this tho https://keeper.atlassian.net/browse/BE-7544.
hleekeeper
changed the title
| parentKind: 'keeper_drive_folder', | ||
| childKind: 'record', | ||
| childUid: recordUid, | ||
| }) |
There was a problem hiding this comment.
I think this is such a good idea that it's maybe worth making this a breaking change (rather than string | RemovedDependency, make children just a set of RemovedDependency). The guessing we have to do on the BE side is no fun and probably caused some bugs. Something to consider (of course all the other dependency additions would have to be updated)
3 participants
No description provided.