feat(pam-extended): add pam extended schedule + discovery-rule subcommands#2014
Open
msawczynk wants to merge 1 commit intoKeeper-Security:releasefrom
Open
feat(pam-extended): add pam extended schedule + discovery-rule subcommands#2014msawczynk wants to merge 1 commit intoKeeper-Security:releasefrom
msawczynk wants to merge 1 commit intoKeeper-Security:releasefrom
Conversation
New keepercommander/commands/pam_extended/ package: - PamExtendedCommand group (schedule, rule sub-groups) - PamExtendedScheduleSetCommand: set PAMRotationSchedule.scheduleData via REST - PamExtendedScheduleDeleteCommand: noSchedule=True via REST - PamExtendedScheduleListCommand: read current schedules - PamExtendedRuleAddCommand: ADD PAMElementData via pam/modify - PamExtendedRuleDeleteCommand: DELETE PAMElementData via pam/modify - PamExtendedRuleListCommand: read rules from PAM DAG Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
pam extendedcommand group with two sub-groups —scheduleandrule— for managing PAM rotation schedules (PAMRotationSchedule.scheduleData) and discovery rules (PAMElementData) via the existingpam/modifyREST endpoint.New commands
Design notes
keepercommander/commands/pam_extended/(4 files, ~400 LOC). No changes to existing files.CryptoUtils.url_safe_str_to_bytesfor UID parsing and the existingKeeperApiRequest/communicate_resttransport — no new network primitives.PamExtendedCommandis wired into the PAM command group viaregister_commandsin__init__.py.Files
keepercommander/commands/pam_extended/__init__.pyregister_commandshookkeepercommander/commands/pam_extended/group_command.pyPamExtendedCommandgroupkeepercommander/commands/pam_extended/schedule_commands.pykeepercommander/commands/pam_extended/discovery_rule_commands.pyTesting
config.json-missing errors are pre-existing in CI).Made with Cursor