KC-706: Updated master password grading to use zxcvbn#1999
Merged
sshrushanth-ks merged 4 commits intoupdate-master-password-zxcvbnfrom May 5, 2026
Merged
Conversation
sshrushanth-ks
changed the title
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
sali-ks
reviewed
Apr 30, 2026
| return _MASTER_PASSWORD_SCORE_MAP[result['score']] | ||
|
|
||
|
|
||
| def is_master_pw_weak(pw_score): # type: (int) -> bool |
Contributor
There was a problem hiding this comment.
These functions are not used anywhere, so maybe we can remove them.
Contributor
Author
There was a problem hiding this comment.
Done, removed.
| def master_password_score(password): # type: (str) -> int | ||
| if not password or not isinstance(password, str): | ||
| return 0 | ||
| result = _zxcvbn.zxcvbn(password) |
Contributor
There was a problem hiding this comment.
We should wrap the external library call in a try except block and also use of .get instead of direct access.
try:
result = _zxcvbn.zxcvbn(password)
return _MASTER_PASSWORD_SCORE_MAP.get(result.get('score'), 25)
except Exception as e:
logging.debug('zxcvbn scoring failed: %s', e)
return 25
Contributor
Author
There was a problem hiding this comment.
Done, added try/except with .get() for safer access. Falls back to 25 (Weak) on any failure.
sshrushanth-ks
added a commit
that referenced
this pull request
May 6, 2026
* Updated master password grading to use zxcvbn * Added zxcvbn to install_requires * Added zxcvbn-based master password strength grading alongside BreachWatch score. * Addressed PR review comments on master_password_score
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes