Fix ShareFolderCommand#1994
Closed
lthievenaz-keeper wants to merge 1 commit intoKeeper-Security:masterfrom
Closed
Conversation
Running this: `sf <folder> -e <user>` yields this error: ` Folder.SharedFolderUpdateUser.manageRecords: Expected an int, got a boolean.` This is because the `SharedFolderUpdateUser` proto accepts `SetBooleanValue` as `manageRecords` and `manageUsers`, but that's not what we're setting conditionally. This isn't a problem for `SharedFolderUpdateTeam` because these accept `bool`. This isn't a problem for `SharedFolderUpdateRecord` because we make sure to only set `SetBooleanValue`
Contributor
Author
|
Closed to re-push into release - see: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running this:
sf <folder> -e <user>yields this error:Folder.SharedFolderUpdateUser.manageRecords: Expected an int, got a boolean.This is because the
SharedFolderUpdateUserproto acceptsSetBooleanValueasmanageRecordsandmanageUsers, but that's not what we're setting conditionally.This isn't a problem for
SharedFolderUpdateTeambecause these acceptbool.This isn't a problem for
SharedFolderUpdateRecordbecause we make sure to only setSetBooleanValue