Fix server and region_label vars in Tunnel Diagnose Command#1987
Open
lthievenaz-keeper wants to merge 4 commits intoKeeper-Security:releasefrom
Open
Fix server and region_label vars in Tunnel Diagnose Command#1987lthievenaz-keeper wants to merge 4 commits intoKeeper-Security:releasefrom
server and region_label vars in Tunnel Diagnose Command#1987lthievenaz-keeper wants to merge 4 commits intoKeeper-Security:releasefrom
Conversation
For GOVCLOUD envs, the `server` variable caused the tested URLs to be: `govcloud.keepersecurity.us` `connect.govcloud.keepersecurity.us` `krelay.govcloud.keepersecurity.us` For servers other than US and GOVCLOUD, the `region_label` variable resolved as `KEEPERSECURITY`, instead of `EU`, `CA`, `AU` and `JP`
Partial color loss for this string: `✓ 8/8 sampled ports reachable` This is because the `_check` function (✓) sets the color back to bright
sk-keeper
force-pushed
the
release
branch
2 times, most recently
from
ccaf00a to
22d8a2d
Compare
When format=table, the TunnelDiagnoseCommand returns 0 or 1 in the CLI, which is not the behavior or any other CLI Command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GOVCLOUD envs, the
servervariable causes the tested URLs to be:govcloud.keepersecurity.usconnect.govcloud.keepersecurity.uskrelay.govcloud.keepersecurity.usInstead of:
keepersecurity.usconnect.keepersecurity.uskrelay.keepersecurity.usFor servers other than
USandGOVCLOUD, theregion_labelvariable resolves asKEEPERSECURITY, instead ofEU,CA,AUandJPAlso:
Edited a print statement to appear entirely in green instead of partially
Removed the int returned when running the command with format=table in the CLI