Fix R 4.6.0 compatibility#10
Merged
Merged
Conversation
- Replace extrafont (archived CRAN Sep 2025) with systemfonts for font detection in .onAttach; drop extrafont::font_import() calls from import_* functions and extrafont::loadfonts() from zzz.R - Remove Remotes: wch/Rttf2pt1 (root cause of extrafont archival) - Rename element_line(size=) to element_line(linewidth=) in theme-kth.R (deprecated in ggplot2 3.4.0) - Remove scale_name= and rename trans= to transform= in continuous_scale() calls in scales.R (both deprecated in ggplot2 3.5+) - Add CLAUDE.md to .gitignore and .Rbuildignore
- Raise Depends R >= 3.3.0 and Imports ggplot2 >= 3.5.0 to match the transform= API already in use - Add n.breaks and guide=waiver() parameters to scale_x/y_percent/comma; guide was previously hardcoded to "none" suppressing all axis guides - Remove duplicate darkgray key from hexes_neo() which could cause 'names attribute length mismatch' error if gray key were absent - Add .claude to .Rbuildignore
mskyttner
force-pushed
the
fix-r46-compatibility
branch
from
d15c035 to
a4cf8e2
Compare
Align hex values in hexes_neo(), _variables.scss, and compiled Bootstrap CSS files with the official KTH style guide at intra.kth.se/style/en/foundations/colors: sand #EBE5E0→#e6e1dd, darkblue #000061→#08004f, lightblue #DEF0FF→#e0edfc, digitalblue #0029ED→#221dd9, red #E86A58→#d8351e, darkred #78001A→#bf2c17, green #4DA060→#3f824e, darkgreen #0D4A21→#366f43, lightgreen #C7EBBA→#d8ffe7, lightyellow #FFF0B0→#FFF080.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extrafont(archived from CRAN Sep 2025, root cause:Rttf2pt1no longer compiles) withsystemfontsfor font detection; remove allextrafont::calls fromzzz.Randimport_*functions; removeRemotes: wch/Rttf2pt1element_line(size=)→element_line(linewidth=)intheme-kth.R(11 occurrences, deprecated in ggplot2 3.4.0)scale_name=and renametrans=→transform=incontinuous_scale()calls inscales.R(deprecated in ggplot2 3.5.0)R >= 3.3.0andggplot2 >= 3.5.0to match the API already in useguide = waiver()andn.breaksparameters toscale_x/y_percent/comma;guidewas previously hardcoded to"none"suppressing all axis guides unconditionallydarkgraykey fromhexes_neo()which could cause a names-length mismatch errorTest plan
R CMD checkpasses with 0 errors, 0 warnings, 0 notes