Implementacja styków no i nc#44
Open
CZIWELLO wants to merge 2 commits into
Hidden character warning
The head ref may contain hidden characters: "Implementacja-styk\u00f3w-NO-i-NC"
Open
Conversation
Add Contact.h and Contact.cpp introducing a Contact element. Defines ContactType enum (NO/NC) and a Contact class inheriting from VirtualElement with an explicit constructor that accepts an address and contact type. Stores address and type members and adds evaluate(MemoryMap&) as a stub (currently returns false/0). TODO: implement evaluate logic to consult MemoryMap and handle NO/NC behavior. (opis przez copilota)
Include MemoryMap, rename constructor parameters from generic names to address and type, and implement Contact::evaluate. The function now returns true only when powerFlow is true and the contact state matches its type (NO reads true from memory, NC reads false). Keeps existing comment explaining behavior.
PEXEL2002
approved these changes
May 15, 2026
PEXEL2002
left a comment
PEXEL2002
left a comment
Member
There was a problem hiding this comment.
next time oznaczaj mnie to szybciej zareaguje
ale co do kodu wygląda git
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opis
Dodano klasę 'Contact' która ma za zadanie reprezentować styki NO oraz NC.
w tym celu utworzono dwa pliki w odpowiednich folderach oraz nadpisano metodę wirtualną 'evaluate' zgodnie ze specyfikacją.
Powiązane zgłoszenie (Issue)
closes #21
Motywacja i kontekst
self explanatory.
Jak zostało to przetestowane?
projekt poprawnie się buduje.
Zrzuty ekranu (jeśli dotyczy):
Rodzaje zmian
Lista kontrolna: