Retail with mop support#212
Open
adi-no95 wants to merge 10 commits into
Open
Conversation
Justw8
reviewed
May 30, 2026
Justw8
reviewed
May 30, 2026
Justw8
reviewed
May 30, 2026
Justw8
reviewed
May 30, 2026
Justw8
reviewed
May 30, 2026
| local _, tpm = ... | ||
|
|
||
| --- @type { [integer]: boolean } | ||
| tpm.ItemTeleports = { |
Owner
There was a problem hiding this comment.
As with HS, can we only load in the separate item list?
Contributor
Author
There was a problem hiding this comment.
I split the original Items file into Items and ItemsFunctions so the functions can be shared.
adi-no95
commented
Jun 7, 2026
| local function setToolTip(self, tpType, id, hs) | ||
| GameTooltip:SetOwner(self, "ANCHOR_NONE") | ||
| local yOffset = globalHeight / 2 | ||
| local yOffset = isClassic and globalHeight or globalHeight / 2 |
Contributor
Author
There was a problem hiding this comment.
Sidenote:
In classic there is only one possible flyout to the right, which is the mop dungeons teleports. If you have more then five of them, the tooltip crosses the top row.
It could be an issue for retail in theory, who only has more then five options in the top most flyout
Contributor
Author
|
@Justw8 I did make some changes. It looks better now :D Btw does curseforge sort out the TOC files for each version of release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#143 Mop Classic version
I made some changes to support both retail and mop-classic.
Notes
This is an initial pass for MoP Classic support — I’ll double-check everything in-game later. Suggestions are welcome 😄
Testing
ToDo