Skip to content

Refactor authored tooling to TypeScript - #2

Merged
JustineDevs merged 2 commits into
mainfrom
dev
Aug 22, 2026
Merged

Refactor authored tooling to TypeScript#2
JustineDevs merged 2 commits into
mainfrom
dev

Conversation

@JustineDevs

Copy link
Copy Markdown
Owner

Summary

  • migrate tests and operational scripts from JavaScript to TypeScript
  • compile test and script entrypoints for Node 18 execution
  • use the TypeScript Next config and keep PostCSS in its supported config format

Verification

  • pnpm check
  • pnpm --filter agent-compat-docs build
  • 53 tests and 41 adapter conformance cases passed

@vercel

vercel Bot commented Aug 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agents Ready Ready Preview Aug 22, 2026 8:29pm

Keep authored SDK, tests, operational scripts, and Next configuration in TypeScript while compiling Node-compatible JavaScript artifacts for execution.

Constraint: Node 18 and framework loaders require compiled JavaScript for runtime entrypoints

Rejected: TypeScript runtime loader dependency | adds runtime coupling and weakens the published package contract

Confidence: high

Scope-risk: moderate

Directive: Keep authored application code in TypeScript; retain JavaScript only where a tool loader requires it or as compiler output

Tested: pnpm check; pnpm --filter agent-compat-docs build; 53 tests and 41 adapter conformance cases passed

Not-tested: Remote CI after this commit
Semantic-release refuses Node 20, so the release workflow must use Node 22 while the package runtime contract remains Node 18.

Constraint: semantic-release requires Node 22.14 or newer

Rejected: Downgrade semantic-release | would discard the current release toolchain

Confidence: high

Scope-risk: narrow

Directive: Keep CI release Node aligned with semantic-release support requirements

Tested: git diff --check; workflow change is configuration-only

Not-tested: semantic-release execution locally because local Node is 20
@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

"files": [
"dist",

P1 Badge Stage the compiled distribution for GitHub Packages

When the tag-triggered github-package.yml workflow runs pnpm publish:github, the staging script still copies only src, while this new files allowlist and the package entry points require dist. Consequently, npm excludes the staged source and publishes a package containing only package.json, README, and LICENSE, so importing @JustineDevs/agents fails. Copy the built dist directory into the staging area instead.


export type * from "./types.js";

P1 Badge Preserve the public result types in generated declarations

This re-export now exposes only the reduced set in types.ts, dropping previously public types such as DetectionResult, CompileResult, ValidationResult, ValidationReport, and RuntimeVerification (as well as the testing ConformanceResult). The implementation also lacks corresponding return annotations, so the generated declaration infers validate() with results: {}; ordinary consumer code such as report.results.cursor no longer type-checks, which is why the converted internal tests and smoke script now cast these values to any. Restore the public interfaces and use them to annotate the exported functions.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@JustineDevs
JustineDevs merged commit 083db8a into main Aug 22, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant