Skip to content

Fixed release workflow to include deepseek - #860

Closed
remielowik wants to merge 1 commit into
JustVugg:mainfrom
remielowik:deekseek-release-build
Closed

Fixed release workflow to include deepseek#860
remielowik wants to merge 1 commit into
JustVugg:mainfrom
remielowik:deekseek-release-build

Conversation

@remielowik

Copy link
Copy Markdown

Summary

Describe the problem and the smallest change that solves it.

Validation

  • make -C c check
  • CUDA changes were tested with make -C c cuda-test (if applicable)
  • Performance claims include hardware, commands, and repeatable measurements

Compatibility

  • The default CPU build remains dependency-free
  • No model files, generated binaries, or benchmark artifacts are included

@JustVugg

JustVugg commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Thank you for picking this up, and sorry for the wasted round trip — the fix landed on dev in #868 before I got to this one.

Two notes for next time, neither of them about the substance:

  • Target dev, not main. main only ever receives merges from dev, so a PR opened against it shows as blocked and cannot go in on its own. That is on us for not saying so plainly enough in CONTRIBUTING.
  • The diff also reflowed quote style across ci.yml ('12.6.2'"12.6.2" and similar) in places unrelated to the change. Repo-wide formatting is being handled separately in Dead code, de-duplication, repo-wide clang-format, and lint gates in CI #798; keeping a fix limited to its own lines makes it much faster to review.

Closing as superseded, not as unwanted. Please do send more.

@JustVugg JustVugg closed this Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants