Skip to content

engine: RAMMAP, NUMA, and telemetry (PR1 of #377 split) - #820

Open
BColsey wants to merge 3 commits into
JustVugg:devfrom
BColsey:successor/pr1-engine
Open

engine: RAMMAP, NUMA, and telemetry (PR1 of #377 split)#820
BColsey wants to merge 3 commits into
JustVugg:devfrom
BColsey:successor/pr1-engine

Conversation

@BColsey

@BColsey BColsey commented Aug 4, 2026

Copy link
Copy Markdown

Draft successor — supersedes #377. One of three dependent PRs reconstructed file-by-file from the frozen green donor 5f6f31a (onto base 72ddb673). Do not merge #377; it is closed as superseded once all three are open + linked.

Scope

Engine C RAMMAP/NUMA + CUDA accounting, strict telemetry parsing, and their tests/docs. Excludes planning, mounts, lifecycle, benchmark, UI.

  • Engine: c/{colibri.c, backend_cuda.cu, compat.h, st.h, telemetry.h}, c/Makefile, c/resource_plan.py
  • Serve/telemetry: c/openai_server.py (PROF parsing)
  • Tests: test_rammap.c, test_resource_masks.c, test_uring.c, test_serve_sentinel.c, test_backend_cuda.cu, test_rammap_e2e.py (parse logic), test_openai_server.py, test_openai_tools_e2e.py, test_fp8_e2e_repack_load.py, test_resource_plan.py
  • Docs: docs/serve_protocol.md, docs/cuda.md

Reconstruction work

  • STRICTEN PROF telemetry parsing (design L78-80): reject field counts other than 10/17/18; read physical_ssd_valid as == "1" (donor uses bool(int(...))); reject non-finite numerics; a malformed known-kind record is a protocol error.
  • Make docs/serve_protocol.md normative at the PROF contract.
  • Hunk-split c/Makefile (test targets here; install rules → PR2) and test_rammap_e2e.py (parse logic here; live tmpfs cells → PR3).

Dependency

None — PR1 is the root. openai_server.py is stdlib-only; C tests compile against PR1 headers only.

Build verification (subagent worktree)

  • make -C c check GREEN end-to-end: C build + 41 test binaries, C suite ALL PASS (0 failures), Python discovery 302 passed / 0 failed / 18 expected skips. Standalone — no PR2/PR3 dependency.

Reconstruction update

PR1 reconstruction landed (commit f56604f): PROF telemetry strictened to exactly 10/17/18 fields + physical_ssd_valid == "1" + finiteness checks; docs/serve_protocol.md made normative; +4 tests. Green: 282 passed / 0 failed. Still TODO: hunk-split Makefile/test_rammap_e2e (organizational).


Update — 2026-08-07: forward-merged upstream/dev (forward-only merge commit; reconstruct history preserved). Conflicts resolved against the green donor 3658a5d; branch rebuilt and tested linux-green (make -C c check exit 0, 403 tests OK; conflicts in c/Makefile, c/openai_server.py, c/st.h, c/telemetry.h). Merged dev @ aa46e7b; GitHub reports this branch MERGEABLE into dev (dev has since advanced to 8d06bd1, but this branch's engine-only changes don't overlap the newer commits, so it stays conflict-free).

@BColsey
BColsey force-pushed the successor/pr1-engine branch from 4dbacf5 to ea46a57 Compare August 9, 2026 12:49
@BColsey

BColsey commented Aug 9, 2026

Copy link
Copy Markdown
Author

Merge order: 1 of 3

Merge this PR first, then merge #821, followed by #822.

Dependency chain: #820#821#822

@BColsey

BColsey commented Aug 9, 2026

Copy link
Copy Markdown
Author

@JustVugg, this PR is ready for review.

The current CI workflow and check workflow are both action_required with no jobs started. Because this is a fork PR, they require approval from a base-repository maintainer before CI can run.

Merge position: 1 of 3#820#821#822.

@BColsey
BColsey marked this pull request as ready for review August 9, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discussion Proposta / discussione aperta, non un task enhancement New feature or request performance Velocità / tok-s / ottimizzazioni

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants