Skip to content

Add options to recompute gradient and/or obj or not on first iteration#280

Merged
MaxenceGollier merged 1 commit into
JuliaSmoothOptimizers:masterfrom
MaxenceGollier:recomputation
Jan 27, 2026
Merged

Add options to recompute gradient and/or obj or not on first iteration#280
MaxenceGollier merged 1 commit into
JuliaSmoothOptimizers:masterfrom
MaxenceGollier:recomputation

Conversation

@MaxenceGollier

Copy link
Copy Markdown
Collaborator

closes #278.

@MaxenceGollier

Copy link
Copy Markdown
Collaborator Author

@dpo, Ideally, i would like to add unit tests but I would like to refactor them first, they are not maintanable as such in my opinion. Could you please take a look at #271 ?

This is blocking for the notion points for this week, and so is #279.

@codecov

codecov Bot commented Jan 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.66%. Comparing base (e0f214d) to head (7540372).
⚠️ Report is 265 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #280       +/-   ##
===========================================
+ Coverage   61.53%   84.66%   +23.13%     
===========================================
  Files          11       13        +2     
  Lines        1292     1624      +332     
===========================================
+ Hits          795     1375      +580     
+ Misses        497      249      -248     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dpo dpo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Did you at least test it with your solver?

@MaxenceGollier

MaxenceGollier commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator Author

Benchmarks are running: MaxenceGollier/Penelopt.jl#47 i will need a release for the tests to pass.

Edit: benchmarks give a good improvement accross all measures, I will merge like so and add tests afterwards.

@MaxenceGollier
MaxenceGollier merged commit 0871eee into JuliaSmoothOptimizers:master Jan 27, 2026
13 of 14 checks passed
@MaxenceGollier
MaxenceGollier deleted the recomputation branch January 27, 2026 19:04
@MaxenceGollier MaxenceGollier mentioned this pull request Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid recomputing gradient and objective function on first iteration

2 participants