[feat] PR with artifact preview#8
Open
sosiristseng wants to merge 12 commits into
Open
Conversation
Author
|
However, I kept getting errors on "Comment on PR about the artifact link" github action: https://github.com/sosiristseng/static-export-template/runs/4544460466?check_suite_focus=true Edit: the latest commit fixed that https://github.com/sosiristseng/static-export-template/actions/runs/1586404343 |
greimel
approved these changes
Jul 29, 2022
greimel
left a comment
greimel
left a comment
Contributor
There was a problem hiding this comment.
This would be nice to have!
Could someone re-trigger CI to verify that the artifacts look good?
greimel
reviewed
Jul 29, 2022
| name: Add artifact links to pull request and related issues | ||
| on: | ||
| workflow_run: | ||
| workflows: ["Export Pluto notebooks"] |
Contributor
There was a problem hiding this comment.
Suggested change
| workflows: ["Export Pluto notebooks"] | |
| workflows: [Export Pluto notebooks] |
In the examples you linked to, there are no quotation marks
Contributor
|
I used your code in greimel/pluto-course-template#15 - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #6