Skip to content

WIP - Adopt XML v0.4 as XLSX v0.12.0#415

Open
TimG1964 wants to merge 12 commits into
JuliaData:masterfrom
TimG1964:XTO-for-pr
Open

WIP - Adopt XML v0.4 as XLSX v0.12.0#415
TimG1964 wants to merge 12 commits into
JuliaData:masterfrom
TimG1964:XTO-for-pr

Conversation

@TimG1964

Copy link
Copy Markdown
Collaborator

…timisations

@codecov-commenter

codecov-commenter commented Jun 28, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 92.04322% with 81 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.25%. Comparing base (fcdba31) to head (01b6489).
⚠️ Report is 51 commits behind head on master.

Files with missing lines Patch % Lines
src/read.jl 90.15% 25 Missing ⚠️
ext/FileIOExt.jl 0.00% 17 Missing ⚠️
src/stream.jl 91.91% 16 Missing ⚠️
src/cell.jl 92.66% 8 Missing ⚠️
src/worksheet.jl 89.13% 5 Missing ⚠️
src/write.jl 96.80% 3 Missing ⚠️
src/conditional-formats.jl 94.59% 2 Missing ⚠️
src/sst.jl 97.61% 2 Missing ⚠️
src/cellformats.jl 96.29% 1 Missing ⚠️
src/formula.jl 95.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
- Coverage   94.62%   94.25%   -0.38%     
==========================================
  Files          21       23       +2     
  Lines        7056     7781     +725     
==========================================
+ Hits         6677     7334     +657     
- Misses        379      447      +68     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

TimG1964 added 5 commits June 29, 2026 14:10
…parsing and SheetCellRef construction entirely, since they never read formula text — closes the gap on formula-heavy sheets without affecting correctness (formula cells still correctly read as missing)
…ith a direct forward code-unit scan — ~2x faster per call, ~10% faster end-to-end on formula-heavy, namespace-prefixed-attribute-bearing real-world-shaped files
…f restarting a fresh full SheetRowStreamIterator — eliminates a redundant worksheet re-decompression in streaming-mode readtable; ~11.5% faster on a 670k-row, long-shared-string fixture (27.74s -> 24.54s), negligible effect on smaller/formula-dominated files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants