small fixes to examples and README#118
Closed
leios wants to merge 1 commit into
Closed
Conversation
Member
|
Thanks! I'm been working on this too in #107 |
Author
|
Ah, fair enough. Sorry for the spam again! |
Member
|
No problem! Let me know if you have any suggestions for #107 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
This is a small PR fixing typos in the README and a few examples
Reference issue
Discussed briefly here: #114
Additional information
I couldn't get the
waterfall_lines.jl,lilyplay.jlorwaterfall_heatmap.jlexamples to run. Here are my rough thoughts on them:lilyplay.jl. I am not really sure what this one should be doing exactly, but it provides the following error:waterfall_lines.jl. This one seems to be broken because of Makie.jl has changed it's API. I don't really know whatax = axis(0:0.1:1, 0:0.1:1, 0:0.1:0.5)is in modern Makiewaterfall_heatmap.jl. I am not sure what the following lines are supposed to be doing:It seems to be broken on
enumerate(IndexCartesian(), dispbufs).dispbufsis a 2D array of 2D arrays andenumerate(IndexCartesian(), a)no longer exists. I triedCartesianIndices(...), but obviouslyiandbufare integers in this case, soheatmap(buf, offset = (i[2] * size(buf, 2), i[1] * size(buf, 1)))breaksI'll keep working on this, I am just creating the PR prematurely to see what you think.